Skip to content

Conversation

@cbegeman
Copy link
Collaborator

This PR increases the generalizability of vertical coordinates by relaxing the assumption that restingThickness spans ssh=0 to bottomDepth. As such, it is tangentially related to inactive top cells. The change affects cases where config_ALE_thickness_proportionality='restingThickness_times_weights', which is the default.

[non-BFB]

@cbegeman cbegeman requested a review from xylar May 23, 2024 21:11
@cbegeman
Copy link
Collaborator Author

This PR is functionally similar to E3SM-Project#5254, except that formulation encountered failures with gnu compilers on chrysalis detailed here E3SM-Project#5564.

@cbegeman
Copy link
Collaborator Author

So far, this PR has small diffs on the following tests:

  • SMS_D_Ld1.TL319_IcoswISC30E3r5.GMPAS-JRA1p5-DIB-PISMF.chrysalis_gnu.mpaso-jra_1958
  • All IcoswISC240_WOA23 tests

@cbegeman
Copy link
Collaborator Author

@xylar As we chatted about, I'm re-opening this PR with a new formulation that seems not to be crashing on gnu compilers now. When you have a chance, take a look at the one commit f9d2573 and let me know what you think!

@xylar xylar changed the base branch from master to alternate May 24, 2024 06:24
@xylar xylar changed the base branch from alternate to master May 24, 2024 06:25
@cbegeman cbegeman force-pushed the ocn-bugfix-zstar-isc-gnu branch from f9d2573 to f5fdf44 Compare May 29, 2024 21:33
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jun 4, 2024

@xylar This case ran successfully (SMS_D_Ld1.TL319_IcoswISC30E3r5.GMPAS-JRA1p5-DIB-PISMF.chrysalis_gnu.mpaso-jra_1958) but I'm having trouble with running even master on chrysalis using a new gnu compass environment.

newThickness ! temp used during min/max adjustment
weightSum, &! sum of weights in vertical
restingThicknessSum, &! total resting thickness
restingThicknessDiff, &! difference from total resting thickness
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call restingThicknessDiff something else (like restingSSH)? It isn't clear what it's the difference with respect to.

@xylar
Copy link
Collaborator

xylar commented Jun 5, 2024

I'm having trouble with running even master on chrysalis using a new gnu compass environment.

Could you share more specifically (perhaps on Slack) what trouble you're running into? I just rebuilt my conda environment and MPAS-Ocean with gnu on Chrysalis and so far I'm having no trouble running the pr suite. Any chance you're past your quota or something like that?

Update: the pr suite finished fine:

/lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240605/pr_gnu

Let me know what I can do to help debug the troubles you're having.

@cbegeman cbegeman force-pushed the ocn-bugfix-zstar-isc-gnu branch from 678f5c6 to 8176242 Compare August 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants