Skip to content

Conversation

@cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented Jul 12, 2025

The critical change here is that remapping needs to be called at the beginning of split time integration in order to work in coupled model configurations, whereas before it occurred during Stage 3 of the split time integration schemes (after baroclinic and barotropic iterations).

The second important change is calling ocn_ALE_thickness from within ocn_vert_regrid to ensure consistency in vertical coordinate. layerThicknessTarget refers to the output of the vertical coordinate routine, which is used to compute the vertical velocity.

There was also a need to change loop limits to nCellsAll rather than nCellsHalo in mpas_ocn_thick_ale.F.

@cbegeman cbegeman changed the base branch from master to alternate July 13, 2025 20:20
@cbegeman cbegeman changed the base branch from alternate to master July 13, 2025 20:20
@cbegeman cbegeman force-pushed the ocn/fix-vertical-remap branch from ddce143 to cef0cf6 Compare July 14, 2025 01:00
@cbegeman
Copy link
Collaborator Author

cbegeman commented Aug 1, 2025

Testing

Internal wave test case with VLR active:

Differences are larger than machine precision, normalVelocity O(1e-5) m/s, layerThickness O(1e-2) m but behavior is similar:

Old
image

New
image

@cbegeman cbegeman force-pushed the ocn/fix-vertical-remap branch from 945ff66 to 65b5c94 Compare August 13, 2025 21:26
@cbegeman cbegeman force-pushed the ocn/fix-vertical-remap branch from 65b5c94 to d73fda7 Compare October 6, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant