-
Notifications
You must be signed in to change notification settings - Fork 0
Remove redundant sea ice enthalpy flux term #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove redundant sea ice enthalpy flux term #135
Conversation
… seaIceHeatFlux deriving from Icepack
|
@vanroekel I wanted to check in with you partly to make sure that we don't need to make any changes to the surface buoyancy forcing used by KPP. I believe we do not need to make any changes there because |
|
Given that @proteanplanet, @alicebarthel and I feel reasonably confident in this change, I am going to proceed with testing this branch with a v3.LR.piControl simulation. For that test, I am using a branch based on the v3.0.2 code base: https://github.com/cbegeman/E3SM/tree/v3.0.2/fix-sea-ice-enthalpy-flux. |
|
Note that if |
|
@cbegeman I agree with your assessment and also that this is a double counting based on previous discussions. |
@alicebarthel That's worth considering. I think there is an argument to be had on the MPAS-Ocean side for forcing it to be 0 for now:
Note to anyone following the discussion: |
|
I agree that we should set it to zero for now. If there is no need to retain compatibility with MPAS-SeaIce using non-mushy thermo then that's even cleaner. I just wanted to make sure we did not inadvertently remove something that is needed/wanted in a different (supported) configuration. |
|
Also FYI, the enthalpy/heat flux counted in both is quite different since |
|
@cbegeman if we need to retain a melt heat flux when MPAS-SeaIce is non-mushy, it'd be easier in practice to add the flux in Icepack since we have |
alicebarthel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on my understanding of the terms accounted for in emlt_ocn. My only caveat is on whether it would be preferable to remove seaIceTemperatureFlux entirely, or keep it as an option for non-mushy sea ice thermodynamics.
TestingI have run through the end of year 69 of a v3.LR.piControl run branched from the v3.LR.spinup: https://e3sm.atlassian.net/wiki/spaces/pd/pages/5581930507/v3.LR.piControl-enthalpyfix Key points:
Analysis shown here is years 1-50, climo years 1-50: |





The enthalpy flux associated with
seaIceFreshWaterFluxis already included inseaIceHeatFluxwhich derives fromfhocnin Icepack. Thus, it was incorrect to apply bothseaIceHeatFluxandseaIceTemperatureFluxin MPAS-Ocean, asseaIceTemperatureFluxprovides the thickness ofseaIceFreshWaterFluxat the freezing point.Here, we set
seaIceTemperatureFluxto 0 always. The variableseaIceTemperatureFluxcould be removed entirely if desired. I retain it here for clarity.