Put ".rtd." in WW3 obstructions/shadow file names #6647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@erinethomas, didn't we also want to include a |
Contributor
Author
|
yes- the mesh files are now called "wQU225Icos30E3r5_rtd.msh" for example.... I forgot to cherry pick that change from my other branch. good catch - thanks! |
Contributor
Author
|
closing to rename branch according to standards. |
Member
|
moved to #6662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WW3 obstructions/shadow files should include ".rtd." in the name.
This stands for 'rotated grid'. It will be much easier to keep track of WW3 input files required. Some input files need to be on the WW3 rotated grid (and should specify this with the tag "rtd" in the file name), while other files need to be on the un-rotated grid.
Note: this PR must be merged BEFORE #6601