fix variables in data subglacial runoff #6672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tenuation_coefficient_subglacial_runoff in subglacial kpp loop
xylar
approved these changes
Oct 9, 2024
Contributor
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
Yes, I agree by inspection that this looks correct and the old value was copied by mistake.
xylar
added
MPAS-ocean
jonbob
added a commit
that referenced
this pull request
Oct 9, 2024
…o next (PR #6672) Fix variables in data subglacial runoff This fixes a typo in PR #6508, where config_flux_attenuation_coefficient_runoff was mistakenly used in kpp loop instead of config_flux_attenuation_coefficient_subglacial_runoff These variables are only used for data subglacial runoff. [BFB] for all tested configurations
Contributor
|
Passes:
but does show DIFF on e3sm_ocnice_extra_coverage test:
merged to next |
Contributor
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Oct 26, 2024
This merge updates the E3SM-Project submodule from [727ad81](https://github.com/E3SM-Project/E3SM/tree/727ad81) to [1442143](https://github.com/E3SM-Project/E3SM/tree/1442143). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6509 - [ ] (ocn) E3SM-Project/E3SM#6508 - [ ] (fwk) E3SM-Project/E3SM#6575 - [ ] (ocn) E3SM-Project/E3SM#6590 - [ ] (fwk) E3SM-Project/E3SM#6643 - [ ] (ocn) E3SM-Project/E3SM#6656 - [ ] (ocn) E3SM-Project/E3SM#6672 - [ ] (ocn) E3SM-Project/E3SM#6659 - [ ] (ocn) E3SM-Project/E3SM#6497 - [ ] (ocn) E3SM-Project/E3SM#6485 - [ ] (ocn) E3SM-Project/E3SM#6566
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo in PR #6508, where config_flux_attenuation_coefficient_runoff was mistakenly used in kpp loop instead of config_flux_attenuation_coefficient_subglacial_runoff.
These variables are only used for data subglacial runoff, so this does not impact current tests.
[BFB]