-
Notifications
You must be signed in to change notification settings - Fork 446
Add new SOwISC12to30E3r4 ocean and sea-ice mesh #7195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new SOwISC12to30E3r4 ocean and sea-ice mesh #7195
Conversation
|
@matthewhoffman and @cbegeman, let's chat about this at our FAnSSIE ocean meeting tomorrow. I think this is ready to go in. That would let me move over to working on coupling updates. |
|
@xylar Do we have an explanation for the large Arctic salinity changes? I see that there are some diffs in river runoff due to the different mapping files but that doesn't seem significant enough to explain the salinity diffs. |
@maltrud Thanks for MPAS-Dev/compass#829 (comment). That puts my mind at ease. |
cbegeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@irenavankova, are you also willing to review this? |
matthewhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar , this looks really good. Thanks for the detailed discussion page and analysis output. I don't have experience reviewing ocean meshes in detail, but I don't see anything that concerns me. This will be a big step forward for FAnSSIE.
irenavankova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Additionally to the freshwater changes in the Arctic associated with new restoring file, I think it is worth mentioning the warmer inner Amundsen Sea continental shelf (almost half a degree warmer on average). From the plots, it doesn't seem to me that the bathymetry on the shelf is that different to cause this. Do you attribute it to internal variability? Or also to the new sss restoring file? In any case the isotherms have a shape closer to observations in V4. Also, for the purpose this mesh is created the +0.5 degrees will be just fine as there will be temperature bias correction on the ice sheet side, I think.
I noticed that, too. I would think it's too big and too systematic to be internal variability. I think the SSS restoring is the more likely explanation but we'd have to run more simulations (e.g. SORRM r3 with the new restoring) to untangle that. For now, that's beyond the scope of this PR but could be on the table for the future. |
|
Thanks everyone for your reviews! |
|
@xylar -- I'm not finding all the files in the inputdata repo. Do you want me to stage them? |
|
Woops! I can copy those over. |
|
@jonbob, I staged all the files that I created with Compass. I think that would still leave the coupling files you created. And potentially any other files you would have added to |
|
Yes, I'll stage whatever I find is not in inputdata |
|
Great, thank you! |
|
OK, I believe all files are now staged |
Add new SOwISC12to30E3r4 ocean and sea-ice mesh Alternative version of the Southern Ocean Regionally Refined (SORRM) mesh. This mesh has resolution that is: * 12 km around Antarctica * 30 km elsewhere In contrast to SOwISC12to30E3r3, this mesh uses ice-sheet and bedrock topography from the MALI #6884 mesh and initial condition. It also uses a new type of sea-surface salinity (SSS) restoring (MPAS-Dev/compass#883) in G-cases. The mesh is with Ice-Shelf Cavities (wISC) around Antarctica and has 80 vertical layers. Its longname is SOwISC12to30kmL80E3SMv3r4 [BFB]
|
passes sanity testing -- merged to next |
|
merged to master |
|
Thanks @matthewhoffman, @cbegeman and @irenavankova or the reviews and thanks @jonbob for testing, reviewing and merging. |
Long name: SOwISC12to30kmL80E3SMv3r4
Alternative version of the Southern Ocean Regionally Refined (SORRM) mesh. Like #6631, this mesh has resolution that is:
In contrast to SOwISC12to30E3r3, this mesh uses ice-sheet and bedrock topography from the MALI #6884 mesh and initial condition. It also uses a new type of sea-surface salinity (SSS) restoring (MPAS-Dev/compass#883) in G-cases.
The mesh is with Ice-Shelf Cavities (wISC) around Antarctica and has 80 vertical layers.
This is a proposed E3SM v3 (E3) mesh for the FAnSSIE SciDAC project. This is revision 4 (r4) of the mesh. The mesh will be tagged on Compass as: https://github.com/MPAS-Dev/compass/releases/tag/mesh_SOwISC12to30E3r4 to aid reproduction in the future.
The mesh and the G-case results will be reviewed here (with a somewhat streamlined review process because this mesh is for FAnSSIE, not E3SM):
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4915200255/Review+SOwISC12to30E3r4
Relevant discussion can be found at:
E3SM-Ocean-Discussion#120