Skip to content

Conversation

@xylar
Copy link
Contributor

@xylar xylar commented Mar 31, 2025

Long name: SOwISC12to30kmL80E3SMv3r4

Alternative version of the Southern Ocean Regionally Refined (SORRM) mesh. Like #6631, this mesh has resolution that is:

  • 12 km around Antarctica
  • 30 km elsewhere

In contrast to SOwISC12to30E3r3, this mesh uses ice-sheet and bedrock topography from the MALI #6884 mesh and initial condition. It also uses a new type of sea-surface salinity (SSS) restoring (MPAS-Dev/compass#883) in G-cases.

The mesh is with Ice-Shelf Cavities (wISC) around Antarctica and has 80 vertical layers.

This is a proposed E3SM v3 (E3) mesh for the FAnSSIE SciDAC project. This is revision 4 (r4) of the mesh. The mesh will be tagged on Compass as: https://github.com/MPAS-Dev/compass/releases/tag/mesh_SOwISC12to30E3r4 to aid reproduction in the future.

The mesh and the G-case results will be reviewed here (with a somewhat streamlined review process because this mesh is for FAnSSIE, not E3SM):
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4915200255/Review+SOwISC12to30E3r4

Relevant discussion can be found at:
E3SM-Ocean-Discussion#120

@xylar xylar added MPAS-ocean Concerning the MPAS-ocean model coupled to E3SM. MPAS-seaice Concerning the MPAS-seaice model BFB PR leaves answers BFB RRM Regionally refined model labels Mar 31, 2025
@xylar
Copy link
Contributor Author

xylar commented Mar 31, 2025

@matthewhoffman and @cbegeman, let's chat about this at our FAnSSIE ocean meeting tomorrow. I think this is ready to go in. That would let me move over to working on coupling updates.

@cbegeman
Copy link
Contributor

@xylar Do we have an explanation for the large Arctic salinity changes? I see that there are some diffs in river runoff due to the different mapping files but that doesn't seem significant enough to explain the salinity diffs.

@cbegeman
Copy link
Contributor

@xylar Do we have an explanation for the large Arctic salinity changes? I see that there are some diffs in river runoff due to the different mapping files but that doesn't seem significant enough to explain the salinity diffs.

@maltrud Thanks for MPAS-Dev/compass#829 (comment). That puts my mind at ease.

Copy link
Contributor

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of @xylar's testing and earlier mesh inspections. Thanks for your careful work on this @xylar!

@xylar xylar requested a review from irenavankova April 1, 2025 14:42
@xylar
Copy link
Contributor Author

xylar commented Apr 1, 2025

@irenavankova, are you also willing to review this?

Copy link
Contributor

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar , this looks really good. Thanks for the detailed discussion page and analysis output. I don't have experience reviewing ocean meshes in detail, but I don't see anything that concerns me. This will be a big step forward for FAnSSIE.

Copy link
Contributor

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Additionally to the freshwater changes in the Arctic associated with new restoring file, I think it is worth mentioning the warmer inner Amundsen Sea continental shelf (almost half a degree warmer on average). From the plots, it doesn't seem to me that the bathymetry on the shelf is that different to cause this. Do you attribute it to internal variability? Or also to the new sss restoring file? In any case the isotherms have a shape closer to observations in V4. Also, for the purpose this mesh is created the +0.5 degrees will be just fine as there will be temperature bias correction on the ice sheet side, I think.

@xylar
Copy link
Contributor Author

xylar commented Apr 7, 2025

@irenavankova,

Do you attribute it to internal variability? Or also to the new sss restoring file?

I noticed that, too. I would think it's too big and too systematic to be internal variability. I think the SSS restoring is the more likely explanation but we'd have to run more simulations (e.g. SORRM r3 with the new restoring) to untangle that. For now, that's beyond the scope of this PR but could be on the table for the future.

@xylar
Copy link
Contributor Author

xylar commented Apr 7, 2025

Thanks everyone for your reviews!

@jonbob
Copy link
Contributor

jonbob commented Apr 7, 2025

@xylar -- I'm not finding all the files in the inputdata repo. Do you want me to stage them?

@xylar
Copy link
Contributor Author

xylar commented Apr 7, 2025

Woops! I can copy those over.

@xylar
Copy link
Contributor Author

xylar commented Apr 7, 2025

@jonbob, I staged all the files that I created with Compass. I think that would still leave the coupling files you created. And potentially any other files you would have added to data/inputdata. Are you good with staging those?

@jonbob
Copy link
Contributor

jonbob commented Apr 7, 2025

Yes, I'll stage whatever I find is not in inputdata

@xylar
Copy link
Contributor Author

xylar commented Apr 7, 2025

Great, thank you!

@jonbob
Copy link
Contributor

jonbob commented Apr 7, 2025

OK, I believe all files are now staged

jonbob added a commit that referenced this pull request Apr 8, 2025
Add new SOwISC12to30E3r4 ocean and sea-ice mesh

Alternative version of the Southern Ocean Regionally Refined (SORRM)
mesh. This mesh has resolution that is:
* 12 km around Antarctica
* 30 km elsewhere
In contrast to SOwISC12to30E3r3, this mesh uses ice-sheet and bedrock
topography from the MALI #6884 mesh and initial condition. It also uses
a new type of sea-surface salinity (SSS) restoring
(MPAS-Dev/compass#883) in G-cases.

The mesh is with Ice-Shelf Cavities (wISC) around Antarctica and has 80
vertical layers. Its longname is SOwISC12to30kmL80E3SMv3r4

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Apr 8, 2025

passes sanity testing -- merged to next

@jonbob jonbob merged commit 86aebf5 into E3SM-Project:master Apr 9, 2025
7 checks passed
@jonbob
Copy link
Contributor

jonbob commented Apr 9, 2025

merged to master

@xylar xylar deleted the ocn-ice/mesh/sowisc12to30e3r4 branch April 10, 2025 00:06
@xylar
Copy link
Contributor Author

xylar commented Apr 10, 2025

Thanks @matthewhoffman, @cbegeman and @irenavankova or the reviews and thanks @jonbob for testing, reviewing and merging.

@xylar xylar mentioned this pull request Jul 4, 2025
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answers BFB MPAS-ocean Concerning the MPAS-ocean model coupled to E3SM. MPAS-seaice Concerning the MPAS-seaice model RRM Regionally refined model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants