Replace a local error_tol in GridCBalanceCheck with common balance_check_tolerance #7425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Replace local error_tol in GridCBalanceCheck with common balance_check_tolerance for maint-3.0
#7426
Merged
bishtgautam
approved these changes
Jun 10, 2025
Member
|
@bishtgautam please merge. |
bishtgautam
added a commit
that referenced
this pull request
Jul 24, 2025
PR #6651 increased the tolerance for column and grid balance check for C, N, and P. However, subroutine GridCBalanceCheck uses a separate error_tol that was not similarly increased. The lower tolerance is exceeded in an SSP370 simulation (#7423), causing the simulation to be aborted. This PR replaces the local error_tol with the common balance_check_tolerance for EcosystemBalanceCheckMod.F90. Fixes #7423 [BFB] If a simulation were to be impacted, it would have failed when exceeding the lower tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6651 increased the tolerance for column and grid balance check for C, N, and P.
However, subroutine GridCBalanceCheck uses a separate error_tol that was not similarly
increased. The lower tolerance is exceeded in an SSP370 simulation (#7423), causing the
simulation to be aborted. This PR replaces the local error_tol with the common
balance_check_tolerance for EcosystemBalanceCheckMod.F90.
Fixes #7423
[BFB] If a simulation were to be impacted, it would have failed when exceeding the lower tolerance.
Note: It is not necessarily a bug but loosely labelled as a bug fix PR.