Refactor FATES interface to directly pass to fates patch data structure #7482
+245
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
2 times, most recently
from
46dd1ae to
7e99bd1
Compare
5 tasks
…w transfer function
…ansfer subroutine
While the associated boundary condition is currently set with a min check against this and nlevsoil, this check should be moved inside fates
Since the max rooting depth is calculated using multiple bc_in variables, handle the logic on the fates side
This will be handle on the fates-side
These have moved into fates
… can/should take place during init_coldstart instead of init This will mostly be the non-global data type variables
Since we pass vert_soilc namelist tag, we can replace this init_soil_depths logic on the fates side
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
from
cdb63c5 to
b391bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.