Skip to content

Conversation

@bartgol
Copy link
Contributor

@bartgol bartgol commented Oct 8, 2025

Instead, when the input YAML seq is empty, we will "trust" the user to provide the correct type when retrieving it.

non BFB: NML only


@jgfouca after this PR, I can prob roll back the addition of Ints/Bools/Floats/Strings that was needed in CIME to handle yaml files in compare_namelists.py...

@bartgol bartgol requested a review from jgfouca October 8, 2025 22:33
@bartgol bartgol self-assigned this Oct 8, 2025
@bartgol bartgol added BFB PR leaves answers BFB EAMxx C++ based E3SM atmosphere model (aka SCREAM) code cleanup non-BFB PR makes roundoff changes to answers. and removed BFB PR leaves answers BFB labels Oct 8, 2025
Copy link
Member

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks a lot cleaner

bartgol added a commit that referenced this pull request Oct 16, 2025
…7776)

Instead, when the input YAML seq is empty, we will "trust"
the user to provide the correct type when retrieving it.

non BFB: NML only
@bartgol bartgol merged commit 2082a77 into master Oct 16, 2025
16 of 21 checks passed
@bartgol bartgol deleted the bartgol/eamxx/rm-user-defined-yaml-tags branch October 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code cleanup EAMxx C++ based E3SM atmosphere model (aka SCREAM) non-BFB PR makes roundoff changes to answers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants