For eamxx, change default number of vertical levels to 128 for ne4/ne30/ne128 #7777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkeen
added
non-BFB
whannah1
approved these changes
Oct 9, 2025
ndkeen
added a commit
that referenced
this pull request
Oct 9, 2025
…7777) Change default vertical levels for eamxx to 128 (from 72). This only impacts ne4/ne30/ne120 as it was already default 128 for ne256/ne512/ne1024. There are some test name changes. Some tests are known to not work yet with 128 vertical levels, so leave those explicitly as L72 for now. Fixes #7347 NBFB (no real changes, but many tests will need to be blessed)
Contributor
Author
|
merged to next |
singhbalwinder
added a commit
that referenced
this pull request
Oct 10, 2025
…7777) Change default vertical levels for eamxx to 128 (from 72). This only impacts ne4/ne30/ne120 as it was already default 128 for ne256/ne512/ne1024. There are some test name changes. Some tests are known to not work yet with 128 vertical levels, so leave those explicitly as L72 for now. Fixes #7347 NBFB (no real changes, but many tests will need to be blessed) * ndk/eamxx/default-vertical-levels-128b: Replaces -- with . to fix the L72 test mod for MAM4xx test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default vertical levels for eamxx to 128 (from 72).
This only impacts ne4/ne30/ne120 as it was already default 128 for ne256/ne512/ne1024.
There are some test name changes.
Some tests are known to not work yet with 128 vertical levels, so leave those explicitly as L72 for now.
Fixes #7347
NBFB (no real changes, but many tests will need to be blessed)