Set eamxx standalone default levels back to 72 #7794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not prepared to go to 128. [BFB]
jgfouca
added
BFB
singhbalwinder
approved these changes
Oct 14, 2025
Contributor
singhbalwinder
left a comment
singhbalwinder
left a comment
There was a problem hiding this comment.
Thanks, Jim and everyone for resolving this failure so quickly!
Contributor
|
I wouldnt consider this "resolved" as we do want to use 128 vertical levels. |
ndkeen
approved these changes
Oct 14, 2025
Member
Author
|
It looks like we lost some testmods in the original PR, I have put those back (the 72 testmod should have been added to the list of test mods, not replace the one that was there). Also, some tests in the CI were missed. |
jgfouca
added
CI: workflow change approved
jgfouca
added a commit
that referenced
this pull request
Oct 14, 2025
Set eamxx standalone default levels back to 72 We were not prepared to go to 128 in standalone. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not prepared to go to 128 in standalone.
[BFB]