-
Notifications
You must be signed in to change notification settings - Fork 446
Finish porting the last of the GW subroutines #7804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
approved these changes
Oct 17, 2025
tcclevenger
approved these changes
Oct 17, 2025
Contributor
tcclevenger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
mahf708
approved these changes
Oct 18, 2025
Contributor
mahf708
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
jgfouca
added a commit
that referenced
this pull request
Oct 20, 2025
Finish porting the last of the GW subroutines This completes the initial GW porting effort. I will probably do a final pass through at some point just to make sure I'm happy with all of it. Ported routines: 1) gw_gw_front_gw_sources 2) gw_front_init 3) gw_front_project_winds 4) gw_cm_src 5) gw_oro_src I discovered a possible bug in the f90 for gw_front_gw_sources which I reported to @whannah1 and have handed that issue off to him. [BFB]
jgfouca
added a commit
that referenced
this pull request
Oct 20, 2025
Finish porting the last of the GW subroutines This completes the initial GW porting effort. I will probably do a final pass through at some point just to make sure I'm happy with all of it. Ported routines: 1) gw_gw_front_gw_sources 2) gw_front_init 3) gw_front_project_winds 4) gw_cm_src 5) gw_oro_src I discovered a possible bug in the f90 for gw_front_gw_sources which I reported to @whannah1 and have handed that issue off to him. [BFB]
jgfouca
added a commit
that referenced
this pull request
Oct 20, 2025
Finish porting the last of the GW subroutines This completes the initial GW porting effort. I will probably do a final pass through at some point just to make sure I'm happy with all of it. Ported routines: 1) gw_gw_front_gw_sources 2) gw_front_init 3) gw_front_project_winds 4) gw_cm_src 5) gw_oro_src I discovered a possible bug in the f90 for gw_front_gw_sources which I reported to @whannah1 and have handed that issue off to him. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the initial GW porting effort. I will probably do a final pass through at some point just to make sure I'm happy with all of it.
Ported routines:
I discovered a possible bug in the f90 for gw_front_gw_sources which I reported to @whannah1 and have handed that issue off to him.
[BFB]