Skip to content

Negative runoff quick-fix #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
+330 −12
Open

Negative runoff quick-fix #7809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
755430b
Add scheme to redirect total Qgwl to top 100 river outlets
May 17, 2025
900af67
Implementation to only redistribute negative Qgwl
Jun 3, 2025
b96bd31
implement offsetting scheme
hydrotian Aug 6, 2025
8cb9508
Reprosum instead of MPI_Allreduce
hydrotian Oct 18, 2025
3306222
Fixing error for Scenario B
hydrotian Oct 18, 2025
9078cba
Fixing error for Scenario A
hydrotian Oct 18, 2025
2fc7068
optimize diagnostic outputs
hydrotian Oct 19, 2025
df6114f
try to fix PEM test fail
hydrotian Oct 27, 2025
8948e32
Revert "try to fix PEM test fail"
hydrotian Oct 30, 2025
c2ca073
fix reprosum error
hydrotian Oct 30, 2025
1bf9a82
remove some diag calculations
hydrotian Oct 30, 2025
39fa31c
detect reprosum problem
hydrotian Oct 31, 2025
f505556
revert to seperate reprosum calls
hydrotian Oct 31, 2025
a91ff9e
another attempt
hydrotian Oct 31, 2025
a28ca9c
PEM test passed
hydrotian Nov 1, 2025
ec68102
remove unused stuff
hydrotian Nov 1, 2025
89d781c
consolidate diagnostic outputs
hydrotian Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/mosart/bld/build-namelist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ else {
add_default($nl, 'RoutingMethod');
add_default($nl, 'DLevelH2R');
add_default($nl, 'DLevelR');
add_default($nl, 'redirect_negative_qgwl');
# add_default($nl, 'finidat_rtm' , 'rof_grid'=>$ROF_GRID, 'simyr'=>$opts{'simyr'}, 'nofail'=>1 );
my $val = 0;
if ($NCPL_BASE_PERIOD eq "year") {
Expand Down
1 change: 1 addition & 0 deletions components/mosart/bld/namelist_files/namelist_defaults_mosart.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ for the CLM data in the CESM distribution
<heatflag>.false.</heatflag>
<do_budget>0</do_budget>
<data_bgc_fluxes_to_ocean_flag>.false.</data_bgc_fluxes_to_ocean_flag>
<redirect_negative_qgwl>.false.</redirect_negative_qgwl>
<rstraflag>.false.</rstraflag>
<rinittemp>283.15</rinittemp>
<ngeom>50</ngeom>
Expand Down
8 changes: 8 additions & 0 deletions components/mosart/bld/namelist_files/namelist_definition_mosart.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,14 @@ Default: .false.
If .true., mosart will read in bgc nutrients and send to ocean.
</entry>

<entry id="redirect_negative_qgwl"
type="logical"
category="mosart"
group="mosart_inparm">
Default: .false.
If .true., mosart will redirect negative qgwl to the ocean.
</entry>

<entry id="rstraflag"
type="logical"
category="mosart"
Expand Down
2 changes: 1 addition & 1 deletion components/mosart/src/cpl/rof_comp_mct.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module rof_comp_mct
inst_index, inst_suffix, inst_name, RtmVarSet, &
wrmflag, heatflag, data_bgc_fluxes_to_ocean_flag, &
inundflag, use_lnd_rof_two_way, use_ocn_rof_two_way, &
sediflag
sediflag, redirect_negative_qgwl
use RtmSpmd , only : masterproc, mpicom_rof, npes, iam, RtmSpmdInit, ROFID
use RtmMod , only : Rtmini, Rtmrun
use RtmTimeManager , only : timemgr_setup, get_curr_date, get_step_size
Expand Down
Loading