HOMME: clean up old and unused code #7811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
BFB
oksanaguba
approved these changes
Oct 20, 2025
mt5555
approved these changes
Oct 20, 2025
Contributor
mt5555
left a comment
mt5555
left a comment
There was a problem hiding this comment.
nice work removing those three "base" classes.
Contributor
Author
|
The gw failures are also in master (Jim is taking care of them). The gh/ci fails are b/c the tests ran before master got the gw header include fix. Merging to next. |
bartgol
added a commit
that referenced
this pull request
Oct 22, 2025
- Remove preqx_acc target - Remove swim target - Remove prim target - Remove old compile scripts [BFB]
jgfouca
added a commit
that referenced
this pull request
Oct 23, 2025
HOMME: clean up old and unused code Merge 2 for this PR to bring in depends file fixes. [BFB]
jgfouca
added a commit
that referenced
this pull request
Oct 23, 2025
HOMME: clean up old and unused code Merge 3 for this PR to fix other references to removed files. [BFB]
bartgol
added a commit
that referenced
this pull request
Oct 24, 2025
- Remove preqx_acc target - Remove swim target - Remove prim target - Remove old compile scripts [BFB]
bartgol
added a commit
that referenced
this pull request
Oct 27, 2025
- Remove preqx_acc target - Remove swim target - Remove prim target - Remove old compile scripts [BFB]
Contributor
Author
|
Homme standalone tests are now passing on next. The fails we see on next do not seem related to this PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BFB]