EAMxx: small fixes related to test support lib #7812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
BFB
jgfouca
approved these changes
Oct 20, 2025
tcclevenger
approved these changes
Oct 20, 2025
Instead, add mesh free grids mgr to the data managers lib. Tests that need it, will already link against data mgrs lib anyways, but this way we don't force upstream libs tests to link against downstream libs. E.g., fields unit tests should not require eamxx_grid to build..
When we reorganized share folder libs, I added the test in share/utils, but did not notice we were testing bfbhash in the main tests folder.
bartgol
force-pushed
the
bartgol/eamxx/fix-test-support-lib
branch
from
cb1e4dc to
bee75ee
Compare
Contributor
Author
|
Failures are the same as in master. This is ready for final review and possibly integration. |
tcclevenger
approved these changes
Oct 22, 2025
jgfouca
approved these changes
Oct 22, 2025
bartgol
added a commit
that referenced
this pull request
Oct 22, 2025
Instead of adding mesh free grids mgr to the test support lib, add it to the data managers lib. This avoids having to link many other share libs (field, grid, remap, etc) to all unit tests. E.g., fields unit tests should not require eamxx_grid to build... [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding mesh free grids mgr to the test support lib, add it to the data managers lib.
This avoids having to link many other share libs (field, grid, remap, etc) to all unit tests.
E.g., fields unit tests should not require eamxx_grid to build...
[BFB]