Parameterizations of fine-scale topographic effects on surface radiation balance in ELM #7813
+938
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@daleihao do not merge master in to your feature branch. Undo that commit. |
daleihao
force-pushed
the
daleihao/lnd/finetop_rad_rebase
branch
2 times, most recently
from
a1efdde to
8e93106
Compare
Collaborator
Author
Done. |
Contributor
|
@daleihao, could you please try to rebase this PR off the latest master as there are few conflicts? thanks. |
bishtgautam
reviewed
Oct 31, 2025
Comment on lines
259
to
260
| !write(iulog,*) 'cosinc_gcell',cosinc_gcell(g) | ||
| !write(iulog,*) 'coszen_gcell',coszen_gcell(g) |
Contributor
There was a problem hiding this comment.
Please delete these lines
bishtgautam
reviewed
Oct 31, 2025
| ! Cosine solar zenith angle for next time step | ||
|
|
||
| deg2rad = SHR_CONST_PI/180._r8 | ||
| do g = bounds%begg,bounds%endg |
Contributor
There was a problem hiding this comment.
I believe it would be better to refactor the code such that the if (use_finetop_rad) is outside the do-loop as:
if (.not. use_finetop_rad) then
do g = bounds%begg,bounds%endg
coszen_gcell(g) = shr_orb_cosz (nextsw_cday, grc_pp%lat(g), grc_pp%lon(g), declinp1)
cosinc_gcell(g) = coszen_gcell(g)
enddo
else
do g = bounds%begg,bounds%endg
coszen_gcell(g) = shr_orb_cosz (nextsw_cday, grc_pp%lat(g), grc_pp%lon(g), declinp1)
...
enddo
enddo
bishtgautam
reviewed
Oct 31, 2025
Comment on lines
543
to
545
| sza(g) = nan | ||
| saa(g) = nan | ||
| cosinc(g) = nan |
Contributor
There was a problem hiding this comment.
Initialize them to spval instead of nan.
bishtgautam
reviewed
Oct 31, 2025
Comment on lines
334
to
341
| allocate(this%f_short_dir (begg:endg)) ; this%f_short_dir (:) = nan | ||
| allocate(this%f_short_dif (begg:endg)) ; this%f_short_dif (:) = nan | ||
| allocate(this%f_short_refl (begg:endg,numrad)) ; this%f_short_refl (:,:) = nan | ||
| allocate(this%f_long_dif (begg:endg)) ; this%f_long_dif (:) = nan | ||
| allocate(this%f_long_refl (begg:endg)) ; this%f_long_refl (:) = nan | ||
| allocate(this%sza (begg:endg)) ; this%sza (:) = nan | ||
| allocate(this%saa (begg:endg)) ; this%saa (:) = nan | ||
| allocate(this%cosinc (begg:endg)) ; this%cosinc (:) = nan |
bishtgautam
reviewed
Oct 31, 2025
Comment on lines
581
to
583
| endif | ||
|
|
||
| if ( use_finetop_rad ) then |
Contributor
There was a problem hiding this comment.
You can combine code to use a single if-conditional
bishtgautam
reviewed
Oct 31, 2025
Comment on lines
+1122
to
+1137
| if (use_top_solar_rad) then | ||
| write(iulog,*) ' use TOP solar radiation parameterization instead of PP' | ||
| else | ||
| write(iulog,*) ' use_top_solar_rad is False, so do not run TOP solar radiation parameterization' | ||
| end if | ||
|
|
||
|
|
||
| if (use_finetop_rad) then | ||
| write(iulog,*) ' use fineTOP radiation parameterization instead of PP' | ||
| else | ||
| write(iulog,*) ' use_finetop_rad is False, so do not run fineTOP radiation parameterization' | ||
| end if | ||
|
|
Contributor
There was a problem hiding this comment.
Need to add a check that both use_top_solar_rad and use_finetop_rad can't be simultaneously true.
Collaborator
Author
diurnal_FSDS.mp4This movie shows the diurnal variation of solar radiation with/without fineTOP over the Sierra Nevada. |
debug & define cosinc_col add model outputs; & modify surface area correction for longwave radiation & debug correct surface area for thermal radiation for soilT module update snowsnicar_AD model change COSINC output name to avoid duplicate fix a small bug in variable name fix small bugs debug debug fix bugs set SZA<85 limit fix small bugs fix one bug and add initialization for few variables fix small bugs delete log output and add control to adjust albedo delete log output delete write output add more outputs like MODIS daytime and nighttime ST debug fix a small bug add MODIS FSNO output fix a bug clean up the code in biogeophys clean up the code in main clean up the code fix urban bug add code to calculate apparent surface albedo for EAM fix a small bug debug debug & modify code to not change for urban landunits debug fix typo debug consider the top effects on upward radaiton to sky debug Conflicts: components/elm/src/biogeophys/SoilFluxesMod.F90 components/elm/src/biogeophys/SurfaceAlbedoMod.F90 components/elm/src/main/atm2lndType.F90 components/elm/src/main/elm_initializeMod.F90 fix a LAI bug delete ; debug & add test add restart variables fix a bug debug debug restart issues remove log output
daleihao
force-pushed
the
daleihao/lnd/finetop_rad_rebase
branch
3 times, most recently
from
7de7a64 to
788aeab
Compare
fix a typo add error message fix a bug to avoid the initilization issue in the debug mode
daleihao
force-pushed
the
daleihao/lnd/finetop_rad_rebase
branch
from
788aeab to
093e6e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add physically-based and computationally-efficient parameterizations (fineTOP; Hao et al., 2025) in ELM to explicitly resolve fine-scale (e.g., 1 km) topographic effects on downward shortwave and longwave radiation as well as land surface radiative properties.
The new parameterization can be turned on by
use_finetop_rad = .true..A test for the new parameterization is added.
[BFB]
Hao, D., Bisht, G., Li, L., & Leung, L. R. (2025). Representing fine-scale topographic effects on surface radiation balance in hyper-resolution land surface models. Journal of Advances in Modeling Earth Systems, 17, e2025MS004987. https://doi.org/10.1029/2025MS004987
See an example movie below