-
Notifications
You must be signed in to change notification settings - Fork 446
Remove where-clauses causing nvidia compiler error #7816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The compiler errors seem to be a bug in the compiler, but eliminating the where-clauses is easy to do.
|
I tested with standalone MALI to ensure these changes were implemented correctly and do not change answers. This module is not used in E3SM. All E3SM tests should pass. |
|
Passes the e3sm_landice_developer suite on chrysalis using the gnu compiler. @ndkeen -- please let me know if I should test on pm-cpu with the nvidia compiler? |
jonbob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this does not impact chrysalis results, but we should wait to merge until we have checked on pm-cpu with the Nvidia compiler
|
Yes last night I ran a e3sm_developer with nvidia compiler on pm-cpu (but only after a quick fix #7821 to allow building for most cases). The tests completed with expected passes/fails. So good to merge, thanks! |
Remove where-clauses causing nvidia compiler error The compiler errors seem to be a bug in the compiler, but eliminating the where-clauses is easy to do. Fixes #6931 [BFB]
|
Ran the e3sm_landice_developer suite on chrysalis using the gnu compiler again, and it passes. Merged to next |
|
merged to master |
The compiler errors seem to be a bug in the compiler, but eliminating the where-clauses is easy to do.
Fixes #6931
[BFB]