Skip to content

Conversation

@matthewhoffman
Copy link
Contributor

@matthewhoffman matthewhoffman commented Oct 21, 2025

The compiler errors seem to be a bug in the compiler, but eliminating the where-clauses is easy to do.

Fixes #6931

[BFB]

The compiler errors seem to be a bug in the compiler, but eliminating
the where-clauses is easy to do.
@matthewhoffman matthewhoffman added the MPAS-albany-landice Concerning the MPAS-Albany land ice model label Oct 21, 2025
@matthewhoffman
Copy link
Contributor Author

I tested with standalone MALI to ensure these changes were implemented correctly and do not change answers. This module is not used in E3SM. All E3SM tests should pass.

@matthewhoffman
Copy link
Contributor Author

matthewhoffman commented Oct 21, 2025

@ndkeen , this should fix #6931

@jonbob jonbob self-assigned this Oct 21, 2025
@jonbob
Copy link
Contributor

jonbob commented Oct 21, 2025

Passes the e3sm_landice_developer suite on chrysalis using the gnu compiler. @ndkeen -- please let me know if I should test on pm-cpu with the nvidia compiler?

@jonbob jonbob added BFB PR leaves answers BFB bug fix PR labels Oct 22, 2025
Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this does not impact chrysalis results, but we should wait to merge until we have checked on pm-cpu with the Nvidia compiler

@ndkeen
Copy link
Contributor

ndkeen commented Oct 22, 2025

Yes last night I ran a e3sm_developer with nvidia compiler on pm-cpu (but only after a quick fix #7821 to allow building for most cases). The tests completed with expected passes/fails. So good to merge, thanks!

jonbob added a commit that referenced this pull request Oct 22, 2025
Remove where-clauses causing nvidia compiler error

The compiler errors seem to be a bug in the compiler, but eliminating
the where-clauses is easy to do.

Fixes #6931

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Oct 22, 2025

Ran the e3sm_landice_developer suite on chrysalis using the gnu compiler again, and it passes. Merged to next

@jonbob jonbob merged commit 2e7b342 into master Oct 24, 2025
2 checks passed
@jonbob jonbob deleted the matthewhoffman/mali/sgh-nvidia-error branch October 24, 2025 16:03
@jonbob
Copy link
Contributor

jonbob commented Oct 24, 2025

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answers BFB bug fix PR MPAS-albany-landice Concerning the MPAS-Albany land ice model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal compiler error with some tests using nvidia compiler (version 24.5/25.5) on pm-cpu

4 participants