Skip to content

Remove a test modifier for one eamxx test #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

Remove a test modifier for one eamxx test #7823

merged 3 commits into from
Oct 23, 2025

Conversation

@ndkeen
Copy link
Contributor

@ndkeen ndkeen commented Oct 22, 2025 •
edited by rljacob
Loading

Remove the output preset modifier for one test that was causing trouble after moving to 128 default vertical levels.

[BFB] (except for the one test that now has a new name and will need baseline generated)

@ndkeen ndkeen self-assigned this Oct 22, 2025
@ndkeen ndkeen added Machine Files BFB PR leaves answers BFB Testing Anything related to unit/system tests pm-gpu Perlmutter machine at NERSC (GPU nodes) labels Oct 22, 2025
@ndkeen ndkeen requested a review from bartgol October 22, 2025 20:31
bartgol
bartgol approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@bartgol bartgol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is BFB, but will cause DIFFs due to missing baselines, right? Maybe we should mark as non-BFB, and explain, so that it makes it easier to filter PRs down the road if when our tests break and we do bisection? No big deal though...

ndkeen added a commit that referenced this pull request Oct 22, 2025
@ndkeen
Merge branch 'ndk/machinefiles/eamxx-remove-a-testmod' into next (PR #…
a8a3989 
…7823)

Remove the output preset modifier for one test that was causing trouble after moving to 128 default vertical levels.

[bfb]
@ndkeen
Copy link
Contributor Author

ndkeen commented Oct 22, 2025

Oh shoot, I missed your comment before merging to next.
Indeed it will require a generation of new baseline for that one test.
But I typically think of this sort of change as BFB, though I see the argument that it's NBFB for that test.

@ndkeen ndkeen merged commit 814f415 into master Oct 23, 2025
8 checks passed
@ndkeen ndkeen deleted the ndk/machinefiles/eamxx-remove-a-testmod branch October 23, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartgol bartgol bartgol approved these changes

Assignees

@ndkeen ndkeen

Labels

BFB PR leaves answers BFB Machine Files pm-gpu Perlmutter machine at NERSC (GPU nodes) Testing Anything related to unit/system tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndkeen @bartgol