-
Notifications
You must be signed in to change notification settings - Fork 446
Make default the customized parameter values and input files for v3HR #7834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wlin7 Thank you. The changes for updating so2 elevated emission file and add the namelist vars for MAM5 look good to me. One suggestion is to change the path for emission files to atm/cam/chem/trop_mozart_aero/emis/. This is for consistency with CMIP6 emission files. The folder name can be CMIP7_2deg and CMIP7_0.5deg or (CMIP7_ne30 and CMIP7_ne120). @hwangacme may have better ideas for the naming. |
proteanplanet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the change for sea ice and it is correct.
vanroekel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the ocean settings and they are as expected
Like your suggested pathnames, @mingxuanwupnnl . The data on disk have been moved to the new path (linked back to the old path for a while for cases being tested). Both for the inputdata server, and lcrc local inputpath. Those links will be removed after some time. The commit (7eb0d1f) updated the paths. |
We used to have ne30 or ne120 in the folder name for CMIP6 emission input files, but 2deg or 0.5deg also works. |
jonbob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on limited testing and a visual inspection
|
@wlin7 : As I mentioned on slack, here is a report on some differences I identified when I compile the WCYCL1850-CMIP7 with this commit (rebased to the recent master), and compared with the namelist from v3.HR test6.1:
while for v3.HR test6.1, we have
|
|
just a comment on @zhangshixuan1987 comment above. The mpaso_in diff doesn't matter for the v3HR since ocean BGC is not active. a question on lnd_in - will master give |
|
@vanroekel -- I did verify that snow_shape = 'hexagonal_plate' is set by default, but I think it's one of the ELM namelist settings that doesn't necessarily get printed out to lnd_in. But I'll double-check |
|
@vanroekel -- I ran a quick test with nothing set in user_nl_elm and saw this in the lnd log: |
|
@jonbob is correct. hex scattering was switched on by default on July 2: https://github.com/E3SM-Project/E3SM/pull/7247/files |
Make default the customized parameter values and input files for v3HR This include the tuning parameters and input files that have been specified via user_nl during development. Necessary changes are made in build-namelist to avoid creating new namelist diffs for existing tests. CMIP7 historical volcanic emission files for standard and high resolution and population density file are also updated. The new defaults values for v3HR ocean and seaice will also be used by standalone ocean/seaice case with RRSwISC6to18E3r5 mesh used by coupled v3HR. [BFB] For existing CMIP6 and CMIP7 based cases.
|
Merged to next |
|
Just for record. The the difference @zhangshixuan1987 posted above on atm_in and mpaso_in are expected, due to the switch to CMIP7. |
This includes the tuning parameters and input files that have been specified
via user_nl during development. Necessary changes are made in build-namelist
to avoid creating new namelist diffs for existing tests.
CMIP7 historical volcanic emission files for standard and high resolution and population
density file are also updated.
The new defaults values for v3HR ocean and seaice will also be used by standalone ocean/seaice
case with RRSwISC6to18E3r5 mesh used by coupled v3HR.
[BFB] For existing CMIP6 and CMIP7 based cases.
Notes:
snow_shape = 'hexagonal'has been made default via #7247e3sm_atm_integrationtest suite passed.