EAMxx: Fixing the grid for LINOZ and OXID files. #7863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhbalwinder
approved these changes
Nov 6, 2025
Contributor
singhbalwinder
left a comment
singhbalwinder
left a comment
There was a problem hiding this comment.
Thanks Oscar for fixing this!
…does not use the same field tags as eamxx.
odiazib
force-pushed
the
oscar/eamxx/fix_remap_test_mam4xx
branch
from
2097cb4 to
c97d0db
Compare
odiazib
commented
Nov 11, 2025
| // NOTE: Sometimes the original data does not use the same field tags as eamxx. | ||
| // For these cases, we need to perform a shallow clone of | ||
| // io_grid because the tags are constant in this object. | ||
| using namespace ShortFieldTagsNames; |
Contributor
Author
There was a problem hiding this comment.
@bartgol I ended up only modifying the grid for the AtmosphereInput here because the other place we talked about did not have any effect. My guess is that when the remapper is created, the grid from the input target grid is not used to set or check the field tags.
bartgol
approved these changes
Nov 11, 2025
singhbalwinder
added
BFB
singhbalwinder
added a commit
that referenced
this pull request
Nov 12, 2025
…xx' into next (PR #7863) EAMxx: Fixing the grid for LINOZ and OXID files. We are using ne30pg2 files for linoz and oxid instead of ne4pg2, which produces an error in the DataInterpolation class because we also provide a remap file. Another piece of code is added to fix the following error: Error! Layout mismatch for input file variable. 26: - filename: /compyfs/inputdata//atm/scream/mam4xx/emissions/ne4pg2/elevated/cmip6_mam4_bc_a4_elev_1x1_2010_clim_ne4pg2_c20250701.nc 26: - varname : BB 26: - expected dims : ncol,lev 26: - dims from file: ncol,altitude It should fix these tests: REP_Ln5.ne30pg2_oECv3.F2010-EAMxx-MAM4xx.pm-gpu_gnugpu.eamxx-mam4xx-remap_emiss_ne4_ne30--eamxx-L72 SMS_Ln5.ne30pg2_oECv3.F2010-EAMxx-MAM4xx.frontier_craygnu-mphipcc.eamxx-mam4xx-remap_emiss_ne4_ne30--eamxx-L72 [BFB] * odiazib/oscar/eamxx/fix_remap_test_mam4xx: EAMxx: Updating files for remap unit test. EAMxx: Using a clone grid to allow reading data from an NC file that does not use the same field tags as eamxx. EAMxx: We must use ne4pg2 files for oxid and LINOZ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using ne30pg2 files for linoz and oxid instead of ne4pg2, which produces an error in the DataInterpolation class because we also provide a remap file.
Another piece of code is added to fix the following error:
It should fix these tests:
REP_Ln5.ne30pg2_oECv3.F2010-EAMxx-MAM4xx.pm-gpu_gnugpu.eamxx-mam4xx-remap_emiss_ne4_ne30--eamxx-L72
SMS_Ln5.ne30pg2_oECv3.F2010-EAMxx-MAM4xx.frontier_craygnu-mphipcc.eamxx-mam4xx-remap_emiss_ne4_ne30--eamxx-L72
[BFB]