Skip to content

Conversation

@mahf708
Copy link
Contributor

@mahf708 mahf708 commented Nov 7, 2025

This pull request makes a small update to the dependency checks in rcs_stats.py by ensuring that the dask library is available before running the script. This is similar to how other required libraries are handled.

[BFB]

@mahf708 mahf708 requested review from Copilot and ndkeen November 7, 2025 22:08
@mahf708 mahf708 added BFB PR leaves answers BFB Testing Anything related to unit/system tests EAMxx C++ based E3SM atmosphere model (aka SCREAM) labels Nov 7, 2025
@mahf708 mahf708 requested a review from bartgol November 7, 2025 22:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds dask as a required Python library dependency for the RCS (Reproducible Climate Statistics) system test.

Key Changes

  • Added dask to the list of ensured Python libraries in rcs_stats.py

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahf708
Copy link
Contributor Author

mahf708 commented Nov 7, 2025

@ndkeen @bartgol one of you should merge ... hopefully that will fix our testing woes, but no guarantees

@bartgol
Copy link
Contributor

bartgol commented Nov 7, 2025

I can merge once the shiny green button appears

bartgol added a commit that referenced this pull request Nov 7, 2025
This pull request makes a small update to the dependency checks
in rcs_stats.py by ensuring that the dask library is available
before running the script.

This is similar to how other required libraries are handled.

[BFB]
@bartgol bartgol merged commit 466111d into master Nov 7, 2025
18 checks passed
@bartgol bartgol deleted the mahf708/eamxx/rcs-dask-hotfix branch November 7, 2025 22:52
@mahf708
Copy link
Contributor Author

mahf708 commented Nov 7, 2025

thank you <3 <3 <3 💌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answers BFB EAMxx C++ based E3SM atmosphere model (aka SCREAM) Testing Anything related to unit/system tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants