Skip to content

Conversation

@bogensch
Copy link
Contributor

This PR addresses an issue that arises when reading variables from an IOP file with fill_ends = false (the default for many fields). In these cases, values near the model top often remain uninitialized because the model only fills pressure levels for which data exist. To ensure consistent initialization, this PR explicitly zero-initializes all variables before reading each field where fill_ends are not applied. Required state variables (T, Q, U, and V) remain unchanged in behavior, as they always apply fill_ends automatically.

In addition, this PR removes the obsolete code block that computed large-scale vertical velocity on the interface grid. That logic was only needed for the Eulerian dy-core version of the SCM and is no longer required.

Also, fix a naming issue where q1obs was being read in where it should be q2obs. This bug has no effect on any of our cases since q2obs is only read in as a diagnostic.

Closes issue #6189

@bogensch bogensch requested a review from rljacob November 14, 2025 23:35
@bogensch bogensch added BFB PR leaves answers BFB SCM single column model labels Nov 14, 2025
@rljacob rljacob self-assigned this Nov 20, 2025
@rljacob rljacob requested review from ndkeen and removed request for rljacob November 20, 2025 00:42
@rljacob rljacob added bug fix PR EAM Fortran-based E3SM Atmosphere Model labels Nov 20, 2025
@ndkeen
Copy link
Contributor

ndkeen commented Nov 20, 2025

With this branch, I tested:

SMS_D_Ln9_P24x1.ne4_ne4.FDPSCREAM-ARM97.pm-cpu_intel

but see error:

17:  (shr_scam_getCloseLatLonPIO) WARNING: Cant find appropriate latitude or longitu
17:  de coordinate variables

17: forrtl: error (65): floating invalid
17: Image              PC                Routine            Line        Source             
17: libpthread-2.31.s  0000148CC7A52910  Unknown               Unknown  Unknown
17: e3sm.exe           00000000038E7DCC  apply_iop_forcing          94  apply_iop_forcing.F90
17: e3sm.exe           0000000003627E0E  se_iop_intr_mod_m         366  se_iop_intr_mod.F90
17: e3sm.exe           00000000035C9161  dyn_comp_mp_dyn_r         470  dyn_comp.F90
17: e3sm.exe           0000000002323687  stepon_mp_stepon_         587  stepon.F90
17: e3sm.exe           0000000000990A21  cam_comp_mp_cam_r         352  cam_comp.F90
17: e3sm.exe           0000000000948A65  atm_comp_mct_mp_a         721  atm_comp_mct.F90
17: e3sm.exe           00000000004CD41F  component_mod_mp_         784  component_mod.F90
17: e3sm.exe           0000000000489918  cime_comp_mod_mp_        3233  cime_comp_mod.F90
17: e3sm.exe           00000000004B5687  MAIN__                    153  cime_driver.F90

I do see that SMS_D_R_Ld5.ne4_ne4.FSCM-ARM97.pm-cpu_intel.eam-scm seems to run OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answers BFB bug fix PR EAM Fortran-based E3SM Atmosphere Model SCM single column model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants