Skip to content

Conversation

@stephenprice
Copy link
Contributor

This PR removes remaining support for IG- and BG- configurations using the 20km, uniform Greenland ice sheet mesh. Because of some overlap with changes made in PR 7892, this PR is marked as draft-only for now. Once 7892 is merged, this branch will be synched with master as updated to a formal PR.

This commit removes basic support for model configurations that use the
20km, uniform resolution Greenland mesh, which is being replaced with
the var. res. 4to40km Greenland mesh. This commit does NOT
remove/replace support that has already been replaced as part of PR
7892, which updates testing support (and associated PE layouts) to use
the 4to40km init. cond. file instead of the 20km file. The assumption is
that these commits will be integrated sequentially.
@stephenprice
Copy link
Contributor Author

stephenprice commented Nov 20, 2025

Note that there is some remaining language regarding the GIS 20km mesh here, in the context of lnd masks:

https://github.com/stephenprice/E3SM/blob/5378ef320334836bc1fc6953bb40e7be4b7d743d/components/elm/bld/namelist_files/namelist_defaults.xml#L640

And similarly at line 642. It may be that we should revisit these masks / regenerate them based on our newer meshes. If nothing else, the existing masks (if still used in the future) should be moved out of the "mpas.gis20km" subdir into one that is relevant to current / supported model configurations.

This should be discussed / resolved as part of this PR.

@stephenprice stephenprice requested a review from jonbob November 20, 2025 19:31
@stephenprice stephenprice added MPAS-albany-landice Concerning the MPAS-Albany land ice model code cleanup labels Nov 20, 2025
@stephenprice stephenprice requested review from darincomeau and trhille and removed request for jonbob November 20, 2025 19:35
@stephenprice
Copy link
Contributor Author

I also just noticed that the 'extra snowlayers test' is still using the 20 km grid. So we would want to update that test to use the 4-to-40km mesh before removing it (or we need to keep the 20 km grid around just for that, which seems silly). I will talk w/ Charlie Z. about that.

@stephenprice
Copy link
Contributor Author

As part of PR 7892, I've update the 'extra snowlayers' test so that it now uses the most recent v3, low-res. configuration (including the GIS 4-to-40km grid). So that conflict should be removed by the time the 'draft' qualifier is removed from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code cleanup MPAS-albany-landice Concerning the MPAS-Albany land ice model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants