Change name of an internal macro to avoid name clash #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
cmake
tcclevenger
approved these changes
Jan 20, 2025
Contributor
Author
|
It builds fine on mappy. Since this macro change is arch-agnostic, I'm going to merge. Edit: it also allow building on sunspot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current name
GET_MACROis way too common. In fact, on SYCL, it clashes with an internal oneapi macro name. This PR makes the name ekat-specific.E3SM Stakeholder Feedback
Needed to merge E3SM-Project/E3SM#6916