Enable testing with CACTS, and add gh actions to use it #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
the
CI: workflow change approved
bartgol
force-pushed
the
bartgol/cacts-and-gh-actions
branch
3 times, most recently
from
9dea0d8 to
bd14060
Compare
bartgol
added
CI: workflow change approved
jgfouca
previously approved these changes
Jul 24, 2025
Contributor
Author
|
I am currently trying to update CACTS main branch with a feature upgrade, to support python syntax in cacts config file. Once that's merged, I will update cacts on pypi, and re-run the workflows. |
bartgol
force-pushed
the
bartgol/cacts-and-gh-actions
branch
from
1d02731 to
8a7f942
Compare
jgfouca
previously approved these changes
Jul 31, 2025
bartgol
force-pushed
the
bartgol/cacts-and-gh-actions
branch
3 times, most recently
from
899a818 to
8f82a39
Compare
bartgol
force-pushed
the
bartgol/cacts-and-gh-actions
branch
from
8f82a39 to
f75cbef
Compare
bartgol
added
CI: workflow change approved
bartgol
commented
Aug 4, 2025
| EKAT_TEST_MAX_THREADS: ${machine.num_run_res if machine.gpu_arch is None else 1} | ||
| EKAT_DISABLE_TPL_WARNINGS: True | ||
| EKAT_DEFAULT_BFB: True | ||
| EKAT_TEST_DOUBLE_PRECISION: True |
Contributor
Author
There was a problem hiding this comment.
I decided that testing both SP and DP in the same build was just simpler. Users can of course override these setting if running locally via -c EKAT_TEST_DOUBLE_PRECISION=OFF.
tcclevenger
previously approved these changes
Aug 4, 2025
bartgol
force-pushed
the
bartgol/cacts-and-gh-actions
branch
from
3d6244a to
952211d
Compare
Contributor
Author
|
In the PR #377 I added a fix to EkatCreateUnitTest that I forgot I also added to this branch. I removed the commit to resolve the conflict. |
jgfouca
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ever since AT1 has been retired, we haven't had any CI in Ekat. This PR introduces CACTS config file, and adds gh workflow files to run testing on SNL machines.