Upgrade adj_diff to handle lambda-like input providers #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I wanted to use adj_diff inside EAMxx's column ops structure (specifically, the compute_midpoint_delta_impl function). But that function has to be callable when the input is not a view, but a lambda. This required an upgrade of adj_diff.
The new interface has an additional argument, which states the last valid index for which we can call
v(k). That's b/c ifvis a lambda, we cannot callv.size(), like we did for views.The old interface for the case where the input is a view is still available, and simply calls the new one with
index_last = v.size()-1.Testing
Upgraded the adj_diff test to test both view and lambda providers
Separate thought: maybe
adj_diffbelongs to theekat::Algorithmpackage?