Split generic and pack-specific decl/def of where expression #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to define a specialization of it even if ekat::Pack is not available
tcclevenger
previously approved these changes
Oct 9, 2025
Contributor
tcclevenger
left a comment
tcclevenger
left a comment
There was a problem hiding this comment.
Looks good, just a typo.
bartgol
force-pushed
the
bartgol/where-expression-mods
branch
from
eb91e2e to
05f9992
Compare
Contributor
Author
|
Merging, as the last force push was just to fix the comment typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, in order to use
where_expression, we MUST include the pack headers. However, a type-agnostic function that wants to use where expression should not have to include pack types decl. The customer of the function may not use packs, and just want to call the fcn with regular builtin types. Hence, we need the "scalar" version ofwhere_expressionto be available outside of the Pack target. Since it does make use of KOKKOS_INLINE_FUNCTION, it does depend on kokkos, so it makes sense to have it in the KokkosUtils target.Testing
Split the unit tests in two (scalar inside kokkos folder, packed inside pack folder), and verified they both compile/run correctly.