Use Kokkos::subview for subview_1 rank 3 specialization #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcclevenger
force-pushed
the
tcclevenger/use_kokkos_subview_for_3d
branch
from
0fb5f35 to
ca6dca4
Compare
Kokkos can correctly assign to layout right with adjusted stride
bartgol
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kokkos::subviewcan handle the case of assigningsubview(v, ALL, i1, ALL)to layout right, no need to use custom ekat function.Motivation
The custom
ekat::subview_1for rank 3+ views will need a major rework/might not be possible when updating to Kokkos 5 (and the new mdspan based view implementation) due to changes in stride calculations for layout right. Updating rank 3 case to useKokkos::subviewensures that we can retain layout right in our most important case, no matter what changes happen toekat::subview_1.Testing
Current testing is adequate IMO. I've manually tested with Kokkos' develop branch with both new and legacy view implementations.