Update testing to C++20 and address warnings #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcclevenger
force-pushed
the
tcclevenger/cpp_20_updates
branch
from
ee0ded2 to
a2ff3f8
Compare
tcclevenger
force-pushed
the
tcclevenger/cpp_20_updates
branch
from
a2ff3f8 to
2e58334
Compare
tcclevenger
force-pushed
the
tcclevenger/cpp_20_updates
branch
2 times, most recently
from
88b8df1 to
23ca911
Compare
Types of warnings: warning: bitwise operation between different enumeration types is deprecated [-Wdeprecated-enum-enum-conversion] warning: compound assignment with ‘volatile’-qualified left operand is deprecated [-Wvolatile] warning: comparison of floating-point type with enumeration type is deprecated [-Wdeprecated-enum-float-conversion] warning: arithmetic between different enumeration types is deprecated [-Wdeprecated-enum-enum-conversion]
tcclevenger
changed the title
tcclevenger
commented
Oct 21, 2025
| #define EKAT_PACK_WHERE_HPP | ||
|
|
||
| #include "ekat_where.hpp" | ||
| #include "ekat_pack.hpp" |
Contributor
Author
There was a problem hiding this comment.
This caused a build error in EAMxx. Is it not tested in EKAT?
Contributor
There was a problem hiding this comment.
Ah, good catch. The unit test includes ekat_pack.hpp before ekat_pack_where.hpp, so the error gets masked (no pun intended).
bartgol
approved these changes
Oct 21, 2025
| Kokkos::single(Kokkos::PerTeam(team_member), [&] () { | ||
| int volatile* const data = &test_data(wi); | ||
| *data += 1; | ||
| *data = *data + 1; |
Contributor
There was a problem hiding this comment.
I'm curious: was the old version causing errors/warnings? If so, any idea why?
Contributor
Author
There was a problem hiding this comment.
A c++20 deprecation
warning: compound assignment with ‘volatile’-qualified left operand is
deprecated [-Wvolatile]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update testing to C++20 and fix C++20 specific warnings (and an additional generic warning).
Motivation
Eventually we will want to update all of E3SM to use C++20, this is a first step.