host_to_device: Add support for when device views are already allocated #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case that is now supported:
So,
viewis an already-allocated view, or could also be an unmanaged view that has already been set up. This was previously not supported as h2d insisted on taking a non-const vector of view handles and it created the device views for you.Motivation
@whannah1 wants to use the API this way.
Testing
I added a test for this in the pack_kokkos unit tests.