Skip to content

Conversation

@mark-petersen
Copy link

@mark-petersen mark-petersen commented Apr 21, 2025

Derivation of non-Boussinesq primitive equations for Omega Version 1.

See compiled document at
https://portal.nersc.gov/project/e3sm/lvroekel/omega_docs/html/design/OmegaV1GoverningEqns.html

Copy link

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly about generalizing the gravitational potential and adding it a few places I think it's missing.

Also, a request to remove the commented-out text to make review easier.

@mark-petersen mark-petersen force-pushed the omega/design-doc-v1-eqns branch from 0b73688 to e70db7a Compare April 21, 2025 19:07
@mark-petersen mark-petersen self-assigned this Apr 23, 2025
@mark-petersen mark-petersen force-pushed the omega/design-doc-v1-eqns branch from c15da50 to e3573b8 Compare April 23, 2025 15:55
@mark-petersen
Copy link
Author

I have added substantial updates based on feedback and conversations this past week. In particular, the document now uses layer mass-thickness $h$ in kg/m^2. Squashing commits, rebasing and pushing a single commit.

@mark-petersen mark-petersen force-pushed the omega/design-doc-v1-eqns branch from 6d6a68d to f4f7b14 Compare May 1, 2025 18:29
@mark-petersen mark-petersen force-pushed the omega/design-doc-v1-eqns branch 3 times, most recently from 6292d53 to c5aa14b Compare May 1, 2025 20:42
+ \nabla_{3D} \cdot \left( \rho {\bf u}_{3D} \otimes {\bf u}_{3D} \right)
= - \nabla_{3D} p
+ \rho {\bf D}^u + \rho {\bf F}^u
$$ (continuous-momentum)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buoyancy term is missing here rho g khat

Copy link
Author

@mark-petersen mark-petersen May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first equation set is the most general, so gravity would be within ${\bf F}^u$ but is not yet specified. A few paragraphs down I begin "Geophysical fluids such as the ocean and atmosphere are rotating and stratified..." and start to make assumptions and call out specific terms. I have the sentence "The gravitational force $g {\bf k}$ is included in ${\bf F}^u$".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, totally missed that. Thanks for the explanation

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that one could include gravity in ${\bf F}^u$ but I would much prefer that we not do so. In my view, it makes a lot of the subsequent derivation clearer if we include $\nabla_{3D} \Phi$ here from the start. I have been pushing for this the whole time and will continue to do so.

Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @mark-petersen, I just have a couple comments.

\rho = f_{eos}(p,\Theta,S).
$$ (continuous-eos)

where conservative temperature, $\Theta$, and salinity, $S$, are examples of tracers $\varphi$.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
where conservative temperature, $\Theta$, and salinity, $S$, are examples of tracers $\varphi$.
where conservative temperature, $\Theta$, and absolute salinity, $S_A$, are examples of tracers $\varphi$.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to work with other types of salinity? If not, I would prefer to just use $S$ for absolute salinity, rather than $S_A$. Likewise, we work with conservative rather than potential temperature, and conservative temperature simply uses $\Theta$.

@mark-petersen mark-petersen force-pushed the omega/design-doc-v1-eqns branch from 28272b3 to 5d872b5 Compare August 6, 2025 21:14
@mark-petersen
Copy link
Author

rebased on head. Squashed small commits about typos, delinting, white space etc, to reduce number of commits. Current compiled version is here:
https://portal.nersc.gov/project/e3sm/mpeterse/omega/design-doc-v1-eqns-Aug6/design/OmegaV1GoverningEqns.html

@mark-petersen
Copy link
Author

A negative sign must be included for the pressure terms derived from the surface force terms. According to Leishman 2025, Chapter 21, above equation 2, "the negative sign indicates that the force is inward and in the opposite direction to the unit normal vector area, which always points outward by convention". Also see discussion in Kundu et al. 2016 page 104 and equation 4.26.

I added that text to the derivation and changed the sign on the pressure gradient throughout, as well as the related grad(z) terms.

Copy link

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for all the work on this everyone. This is a great resource.

@katsmith133 katsmith133 self-requested a review August 13, 2025 15:07
@mark-petersen mark-petersen merged commit 10d7afb into E3SM-Project:develop Aug 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants