-
Notifications
You must be signed in to change notification settings - Fork 7
Omega V1 Governing Equations Design Document #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omega V1 Governing Equations Design Document #223
Conversation
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, mostly about generalizing the gravitational potential and adding it a few places I think it's missing.
Also, a request to remove the commented-out text to make review easier.
0b73688 to
e70db7a
Compare
c15da50 to
e3573b8
Compare
|
I have added substantial updates based on feedback and conversations this past week. In particular, the document now uses layer mass-thickness |
6d6a68d to
f4f7b14
Compare
6292d53 to
c5aa14b
Compare
| + \nabla_{3D} \cdot \left( \rho {\bf u}_{3D} \otimes {\bf u}_{3D} \right) | ||
| = - \nabla_{3D} p | ||
| + \rho {\bf D}^u + \rho {\bf F}^u | ||
| $$ (continuous-momentum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the buoyancy term is missing here rho g khat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first equation set is the most general, so gravity would be within
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, totally missed that. Thanks for the explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that one could include gravity in
sbrus89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @mark-petersen, I just have a couple comments.
| \rho = f_{eos}(p,\Theta,S). | ||
| $$ (continuous-eos) | ||
|
|
||
| where conservative temperature, $\Theta$, and salinity, $S$, are examples of tracers $\varphi$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| where conservative temperature, $\Theta$, and salinity, $S$, are examples of tracers $\varphi$. | |
| where conservative temperature, $\Theta$, and absolute salinity, $S_A$, are examples of tracers $\varphi$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to work with other types of salinity? If not, I would prefer to just use
fix trailing whitespace Fixes broken cross refs
small change to section formatting Co-authored-by: Hyun (Hyun-Gyu) Kang <[email protected]>
linting fixes updates links
enables numfigs package to allow for figure numbering in design docs
28272b3 to
5d872b5
Compare
|
rebased on head. Squashed small commits about typos, delinting, white space etc, to reduce number of commits. Current compiled version is here: |
|
A negative sign must be included for the pressure terms derived from the surface force terms. According to Leishman 2025, Chapter 21, above equation 2, "the negative sign indicates that the force is inward and in the opposite direction to the unit normal vector area, which always points outward by convention". Also see discussion in Kundu et al. 2016 page 104 and equation 4.26. I added that text to the derivation and changed the sign on the pressure gradient throughout, as well as the related grad(z) terms. |
sbrus89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thanks for all the work on this everyone. This is a great resource.
Derivation of non-Boussinesq primitive equations for Omega Version 1.
See compiled document at
https://portal.nersc.gov/project/e3sm/lvroekel/omega_docs/html/design/OmegaV1GoverningEqns.html