Add Vertical Advection design document #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanroekel
reviewed
Nov 3, 2025
|
|
||
| ### 2.3 Requirement: Compute tendencies for mass, momentum, and tracers | ||
|
|
||
| Separate methods are neededto compute the vertical-advection tendencies |
Collaborator
There was a problem hiding this comment.
Suggested change
| Separate methods are neededto compute the vertical-advection tendencies | |
| Separate methods are needed to compute the vertical-advection tendencies |
vanroekel
reviewed
Nov 3, 2025
| for mass, momentum, and tracers. Mass (`LayerThickness`) and horizontal | ||
| momentum (`NormalVelocity`) are stored as 2-D arrays. `LayerThickness` is | ||
| cell-centered, while `NormalVelocity` is defined on edges. These tendencies | ||
| use a first-order flux formulation that ensures strict conservation and energy |
Collaborator
There was a problem hiding this comment.
do we really use first order? I thought thickness advection was centered (2nd order), but I could be misremembering
vanroekel
reviewed
Nov 3, 2025
| This first-order form ensures exact conservation of total column thickness and | ||
| numerical stability. | ||
|
|
||
| ### 3.3 Momentum (Velocity) |
Collaborator
There was a problem hiding this comment.
we should call this the velocity equation, it is not momentum as defined
vanroekel
reviewed
Nov 3, 2025
| update the tracer tendencies. | ||
|
|
||
| The `computeFCTVAdvTend` method implements the flux-corrected transport scheme | ||
| following Zalesak 1979. At each interface, both a high-order flux (chosen via |
Collaborator
There was a problem hiding this comment.
Are we using zalesak? isn't that 1st order 2nd order? I guess the principle is the same though, but maybe cite this too for the high order part?
Collaborator
There was a problem hiding this comment.
sorry forgot the citation - https://journals.ametsoc.org/view/journals/mwre/139/9/mwr-d-10-05056.1.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the design document for the vertical advection module. Compiled here.
Checklist