fixes stream read failure when freq is never #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adds some error checking to diagnose problems if both InitialState and RestartRead fail
|
Thanks so much, @philipwjones! I'll test this out carefully tomorrow. |
xylar
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Thanks so much @philipwjones! I can confirm that both CTests and the omega_pr suite now pass for me with this branch and E3SM-Project/polaris#384 on Chrysalis.
Polaris omega_pr suite
- PR build:
/gpfs/fs1/home/ac.xylar/e3sm_work/polaris/fix-omega-manufatured-solution/build_omega/build_chrysalis_intel - PR workdir:
/lcrc/group/e3sm/ac.xylar/polaris_0.9/chrysalis/test_20251030/fix-omega-pr - Machine: chrysalis
- Partition: compute
- Compiler: intel
- Build type: Release
- Log:
/lcrc/group/e3sm/ac.xylar/polaris_0.9/chrysalis/test_20251030/fix-omega-pr/polaris_omega_pr.o996864 - Result: All tests passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the frequency of a stream is never, the read routine should return an error, but during the recent propagation of error codes, the read routine was aborting instead. This fixes that and also adds some error checking to diagnose problems if both InitialState and RestartRead fail
I have tested this with the standalone driver unit test with the InitialState as never in the config, but was unable to test with the polaris restart tests due to problems getting a working updated polaris.
Fixes #306
Checklist