Skip to content

Conversation

@erinethomas
Copy link

Pull Request Summary

This PR adds surface roughness and friction velocity to the output fields from WW3, both of which are required for wave-momentum coupling in E3SM.

@sbrus89 sbrus89 self-assigned this Aug 6, 2025
@sbrus89 sbrus89 self-requested a review August 6, 2025 14:00
@proteanplanet
Copy link

What is the status of this PR? Are we waiting on a review by @sbrus89?

@erinethomas
Copy link
Author

Yes - I believe @sbrus89 is testing this with the corresponding E3SM PR (E3SM-Project/E3SM#7713)

@sbrus89
Copy link
Collaborator

sbrus89 commented Oct 23, 2025

This branch passes:

ERS_Ld3_P512.ne30pg2_IcoswISC30E3r5_wQU225Icos30E3r5.WCYCL1850-WW3.chrysalis_intel 
PET_Ld1.ne30pg2_IcoswISC30E3r5_wQU225Icos30E3r5.WCYCL1850-WW3.chrysalis_intel
SMS_D_Ln3.ne30pg2_IcoswISC30E3r5_wQU225Icos30E3r5.WCYCL1850-WW3.chrysalis_intel
SMS_D_Ln3.TL319_EC30to60E2r2_wQU225EC30to60E2r2.GMPAS-JRA1p5-WW3.chrysalis_intel.ww3-jra_1958

in conjunction with E3SM-Project/E3SM#7713. Baseline comparisons are BFB with expected fieldlist diffs.

Copy link
Collaborator

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing above.

@sbrus89
Copy link
Collaborator

sbrus89 commented Oct 23, 2025

@erinethomas, I'm going to merge this and then the WW3 submodule for E3SM-Project/E3SM#7713 can be updated.

@sbrus89 sbrus89 merged commit 62e77e7 into E3SM-Project:e3sm Oct 23, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants