Skip to content

Conversation

@chengzhuzhang
Copy link
Contributor

@chengzhuzhang chengzhuzhang commented Apr 15, 2025

Description

The CERES EBAF TOA variables are accidentally left out a while ago when transitioning to use CERES EBAF v4.1 from v4.0. This PR added back these variables, as well as surface wind speed U10 to compare with ERA5 data.
Example output for these new variables are available here.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@chengzhuzhang chengzhuzhang requested a review from wlin7 April 15, 2025 18:01
@chengzhuzhang
Copy link
Contributor Author

@wlin7 This PR added the variables that you requested. Could you please give a review of the variable list, as well as the results? Thank you for catching the issue, and suggesting the change!

@chengzhuzhang
Copy link
Contributor Author

@wlin7 just a gentle reminder about reviewing the results for this PR, thanks!

@chengzhuzhang chengzhuzhang merged commit 7692014 into main May 2, 2025
6 checks passed
@chengzhuzhang chengzhuzhang deleted the add_vars_to_polar_965 branch May 2, 2025 18:38
@wlin7
Copy link

wlin7 commented May 2, 2025

Thank you for this addition, @chengzhuzhang . Sorry I didn't notice this email thread until the latest when it was merged.

@chengzhuzhang
Copy link
Contributor Author

no worries, wuyin @wlin7. We are planning to release a bug fix version for addressing recent errors, and try to wrap up some bug fix PRs. Feel free to let us know if more issues or new features need to be addressed. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Add new fields to Polar set

3 participants