Skip to content

Conversation

@mahf708
Copy link
Contributor

@mahf708 mahf708 commented May 21, 2025

Description

Exposes AODvis in EAMxx to e3sm_diags infrastructure.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@mahf708 mahf708 added enhancement Easy A subjectively easy task. labels May 21, 2025
@mahf708 mahf708 linked an issue May 21, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the AODvis (Aerosol Optical Depth at 550 nm) variable from EAMxx into the e3sm_diags derivations module.

  • Introduces a new input mapping for the EAMxx variable name "AerosolOpticalDepth550nm".
  • Ensures that both lowercase and uppercase inputs are renamed consistently to "AODVIS" and converted to dimensionless units.
Comments suppressed due to low confidence (1)

e3sm_diags/derivations/derivations.py:852

  • Add or update a unit test to verify that the new "AerosolOpticalDepth550nm" input correctly maps to the standard AODVIS derivation and that units conversion is applied as expected.
("AerosolOpticalDepth550nm",): rename,  # EAMxx

@chengzhuzhang
Copy link
Contributor

chengzhuzhang commented May 21, 2025

@mahf708 thanks for the PR! I haven't forgot about this issue, but added a fix to another EAMxx PR, not yet committed.. Let's merge this so folks can start to use with main branch. Tagging @meng630

@chengzhuzhang chengzhuzhang merged commit 9cb5727 into main May 21, 2025
6 checks passed
@chengzhuzhang chengzhuzhang deleted the 981-feature-support-aod-diagnostic-in-eamxx branch May 21, 2025 22:50
@mahf708
Copy link
Contributor Author

mahf708 commented May 21, 2025

No worries, I was just browsing around, and I thought, I could do this quickly and help out with a quick contribution 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Easy A subjectively easy task. enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support AOD diagnostic in EAMxx

3 participants