Skip to content

Conversation

@chengzhuzhang
Copy link
Contributor

Reverts #984

When I tested again after merging the PR, the pdf plots all return as eampty pdfs. Before merging the PR I might have tested an early commit before the refactor commit.

@tomvothecoder
Copy link
Collaborator

I will work on this today to see why plots are empty. Can you provide the minimum Python script? Otherwise I'll adapt the command line here.

@tomvothecoder
Copy link
Collaborator

Good idea to try to keep this commit because it reduces the repeated logic to make the code cleaner. The empty pdf might be a simple fix.

@chengzhuzhang
Copy link
Contributor Author

I will work on this today to see why plots are empty. Can you provide the minimum Python script? Otherwise I'll adapt the command line here.

I don't have the Python script, but only used those command lines to produce results for each set being changed. I think you can just use the aerosol_aeronet line because it runs faster than others. The refactored version may impact all sets. That's why I was hesitating to make more refactor when working on this PR...but if we can quickly find a simple fix, that would be great.

@chengzhuzhang
Copy link
Contributor Author

main is fixed by #989, no longer need to revert

@chengzhuzhang chengzhuzhang deleted the revert-984-fix/fix_pdf_padding branch June 12, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants