Skip to content

Conversation

@tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jul 8, 2025

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Jul 8, 2025
@tomvothecoder tomvothecoder added the bug Bug fix (will increment patch version) label Jul 8, 2025
@tomvothecoder
Copy link
Collaborator Author

The example from #990 now runs successfully.

e3sm_diags enso_diags --no_viewer --reference_data_path '/lcrc/soft/climate/e3sm_diags_data/obs_for_e3sm_diags/time-series' --test_data_path '/lcrc/group/e3sm/ac.zhang40/example_v3/v3.LR.historical_0051/post/atm/180x360_aave/ts/monthly/5yr' --results_dir '/lcrc/group/e3sm/public_html/diagnostic_output/ac.tvo/tests/pdf_size_1'  --case_id 'TAUX-feedback' --ref_timeseries_input --test_timeseries_input --run_type 'model_vs_obs' --sets 'enso_diags' --variables 'TAUX' --seasons 'ANN' --regions 'global' --regrid_tool 'xesmf' --regrid_method 'conservative_normed' --multiprocessing --num_workers '8' --main_title 'TAUX anomaly (NINO4) vs. TS anomaly (NINO3)' --backend 'mpl' --output_format 'png' --output_format_subplot 'pdf' --canvas_size_w '1212' --canvas_size_h '1628' --figsize '8.5' '11.0' --dpi '150' --arrows --test_name 'v3.LR.historical_0101' --short_test_name 'v3.LR.historical_0101' --test_colormap 'cet_rainbow.rgb' --ref_name 'ERA-Interim' --reference_name 'ERA-Interim' --reference_colormap 'cet_rainbow.rgb' --diff_title 'Model - Observations' --diff_colormap 'diverging_bwr.rgb' --granulate 'variables' 'plevs' 'regions' --selectors 'sets' 'seasons' --test_start_yr '1985' --test_end_yr '2014' --ref_start_yr '1979' --ref_end_yr '1989' --output_format_subplot 'pdf' --plot_type 'scatter'

@tomvothecoder tomvothecoder force-pushed the bug/990-xcdat-bnds-dim branch from 68642db to c9bef4e Compare July 8, 2025 21:08
@tomvothecoder
Copy link
Collaborator Author

Hi @chengzhuzhang, this PR is ready for review. Can you also verify that the example from #990 is working for you too? You'll need to build and use the dev env with the dev.yml from this branch.

Once you confirm it is working, feel free to merge this PR.

@chengzhuzhang
Copy link
Contributor

@tomvothecoder I can confirm the enso plot created without errors with the new env that includes xcdat0.9.1.

@chengzhuzhang chengzhuzhang merged commit 821c84e into main Jul 9, 2025
6 checks passed
@chengzhuzhang chengzhuzhang deleted the bug/990-xcdat-bnds-dim branch July 9, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix (will increment patch version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError: Invalid bounds dimension. from enso_diags with latest xcdat0.9.0

3 participants