Skip to content

Conversation

@tomvothecoder
Copy link
Collaborator

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Sep 3, 2025
@tomvothecoder tomvothecoder added this to the FY25 Development milestone Sep 3, 2025
@tomvothecoder tomvothecoder merged commit f340851 into master Sep 3, 2025
7 checks passed
@tomvothecoder tomvothecoder deleted the bump/v1.12.2 branch September 3, 2025 19:35
@github-project-automation github-project-automation bot moved this from In progress to Done in E3SM to CMIP Development Sep 3, 2025
chengzhuzhang added a commit that referenced this pull request Sep 30, 2025
* add new v3 atm var handlers

* Add formulas for `clmodis`, `clmodisice`, `clmodisliquid`

* Make each MPAS temp directory unique under `outpath_path` (#310)

Co-authored-by: Xylar Asay-Davis <[email protected]>

* Remove unnecessary Python < 3.10 __future__ and typing imports (#312)

* Bump to v1.12.1 (#311)

* Ensure uniqueness for user_metadata.json` by appending PID (#314)

* Bump to 1.12.2 (#315)

* Drop Python 3.10 support (#318)

* Fix areacello handler unlimited dimensions error (#319)

Fixes issue where areacello processing fails with "Unlimited dimension(s) {'time'} declared in 'unlimited_dims-kwarg', but not part of current dataset dimensions" error.

The remap() function was unconditionally setting 'time' as an unlimited dimension, but areacello datasets don't have a time dimension since they represent time-invariant ocean cell areas. Now checks if 'time' dimension exists before setting it as unlimited.

Fixes #317

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <[email protected]>

* fix clmodis;remove clmodisice and clmodisliquid

* add clmodis handler

* add new v3 atm var handlers

* Add formulas for `clmodis`, `clmodisice`, `clmodisliquid`

* fix clmodis;remove clmodisice and clmodisliquid

* add clmodis handler

* fix missing string format

---------

Co-authored-by: Tom Vo <[email protected]>
Co-authored-by: Xylar Asay-Davis <[email protected]>
Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants