-
Notifications
You must be signed in to change notification settings - Fork 7
Preserve legacy Xarray data_vars settings
#325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the codebase to centralize legacy Xarray merge settings by introducing a LEGACY_XARRAY_MERGE_SETTINGS constant in the __init__.py module. This replaces repeated inline configuration of compat and join parameters across multiple files with a single source of truth.
- Introduced
LEGACY_XARRAY_MERGE_SETTINGSdictionary ine3sm_to_cmip/__init__.pyto centralize Xarray legacy behavior settings - Replaced inline
compat="no_conflicts"andjoin="outer"parameters with the new constant across four files - Added
data_vars="all"to the legacy settings dictionary for consistency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| e3sm_to_cmip/init.py | Defines LEGACY_XARRAY_MERGE_SETTINGS constant with legacy Xarray merge parameters |
| e3sm_to_cmip/mpas.py | Replaces inline legacy settings with LEGACY_XARRAY_MERGE_SETTINGS in two locations |
| e3sm_to_cmip/cmor_handlers/mpas_vars/pso.py | Replaces inline legacy settings with LEGACY_XARRAY_MERGE_SETTINGS |
| e3sm_to_cmip/cmor_handlers/mpas_vars/pbo.py | Replaces inline legacy settings with LEGACY_XARRAY_MERGE_SETTINGS |
| e3sm_to_cmip/cmor_handlers/handler.py | Replaces inline legacy settings with LEGACY_XARRAY_MERGE_SETTINGS |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
data_vars="all"#324Checklist
If applicable: