326 force nan replacement

[TonyB9000]

Description

The v3.LR cases failed to support the CMIP6 variable `CFmon.clisccp" due to NaNs in the data where the standard FILL_Value was expected. Code is supplied in the cmor_handlers/vars/clisccp.py module that forces the replacement with the required FILL_Value, prior to calling cmor.write().

• Closes [Bug]: failure to cmorize v3.LR variable CFmon.clisccp due to NaNs in data #326

Checklist

• [y] My code follows the style guidelines of this project
• [y] I have performed a self-review of my own code
• [?] My changes generate no new warnings
• [na] Any dependent changes have been merged and published in downstream modules

If applicable:

• New and existing unit tests pass with my changes (locally and CI/CD build)
• I have added tests that prove my fix is effective or that my feature works
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

[tomvothecoder]

@TonyB9000 You accidentally branched from my branch in PR #323. Can you instead branch from main and add your changes, then re-create this PR.

Alternatively, you can run git rebase on the latest commit of main and drop all commits related to #323 (the more complicated way if you're not familiar with this process).

[tomvothecoder]

I actually don't see your np.nan fix in this branch either. I suggest just re-creating the branch from main with your np.nan fix, then re-creating this PR.

[TonyB9000]

@tomvothecoder So ... I switched to my local "master" branch, then deleted my local branch 326-force-NAN-replacement. Then I did a "git pull" to obtain the master changes:

From https://github.com/E3SM-Project/e3sm_to_cmip
   f90e4ab..7c7f400  master            -> origin/master
 * [new branch]      bug/324-data-vars -> origin/bug/324-data-vars
Updating 19e3ee8..7c7f400
Fast-forward
 e3sm_to_cmip/__init__.py                    |  13 ++++++++++++-
 e3sm_to_cmip/cmor_handlers/handler.py       |   2 ++
 e3sm_to_cmip/cmor_handlers/handlers.yaml    |  48 ++++++++++++++++++++++++++++++++++++++++++++++++
 e3sm_to_cmip/cmor_handlers/mpas_vars/pbo.py |   9 +++++++--
 e3sm_to_cmip/cmor_handlers/mpas_vars/pso.py |   9 +++++++--
 e3sm_to_cmip/cmor_handlers/vars/clmodis.py  | 178 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 e3sm_to_cmip/mpas.py                        |   8 +++++++-
 e3sm_to_cmip/runner.py                      |   2 +-
 tbump.toml                                  |   2 +-
 9 files changed, 263 insertions(+), 8 deletions(-)
 create mode 100644 e3sm_to_cmip/cmor_handlers/vars/clmodis.py

Then I did git checkout -b 326-force-NAN-replacement (switched to new branch).

I went to edit "cmor_handlers/vars/clisccp.py", and found that my changes were still in place.

SO, I did the git add and git commit -m message.

When I tried: git push --set-upstream origin 326-force-NAN-replacement, I got

To https://github.com/E3SM-Project/e3sm_to_cmip
 ! [rejected]        326-force-NAN-replacement -> 326-force-NAN-replacement (non-fast-forward)
error: failed to push some refs to 'https://github.com/E3SM-Project/e3sm_to_cmip'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. If you want to integrate the remote changes,
hint: use 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

So, the problem is I deleted my local "new branch" but not its "remote counterpart"

Next: git push origin --delete 326-force-NAN-replacement

and git push --set-upstream origin 326-force-NAN-replacement

SUCCESS

[TonyB9000]

Reopened after deleting the branch and branching from main (git pulled to bring up-to-date).

[TonyB9000]

@tomvothecoder Am I close? I assume re-opening resumes the PR.

[tomvothecoder]

@TonyB9000 Now you need to open a new PR with the fixed branch.