-
Notifications
You must be signed in to change notification settings - Fork 7
Replace np.nan with FILL_VALUE in clisccp.py for cmor.write
#328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import xarray as xr | ||
|
|
||
| from e3sm_to_cmip._logger import _setup_child_logger | ||
| from e3sm_to_cmip.cmor_handlers import FILL_VALUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to use an already defined FILL_VALUE
clisccp.py for cmor.write
|
I will merge once the GitHub Actions build is complete. Thanks @TonyB9000! |
|
Thanks for the PR. @TonyB9000 and @tomvothecoder . I think we should consider apply the same fix for https://github.com/E3SM-Project/e3sm_to_cmip/blob/master/e3sm_to_cmip/cmor_handlers/vars/clmodis.py before a new e3sm_to_cmip release. |
|
I just released v1.13.0rc2 on GitHub and almost done on conda-forge. I'll quickly apply this fix to |
|
@tomvothecoder Excellent. Thanks Tom! |
e3sm_to_cmip 1.13.0rc3 will be ready within the next hour: conda-forge/e3sm_to_cmip-feedstock#44 |
Description
The v3.LR cases failed to support the CMIP6 variable `CFmon.clisccp" due to NaNs in the data where the standard FILL_Value was expected. Code is supplied in the cmor_handlers/vars/clisccp.py module that forces the replacement with the required FILL_Value, prior to calling cmor.write().
Checklist
If applicable: