Skip to content

Conversation

@tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Oct 30, 2025

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder
Copy link
Collaborator Author

tomvothecoder commented Oct 30, 2025

@TonyB9000 @chengzhuzhang any new bugs come up with v1.13.0rc3?

If not, I think we're ready to release v1.13.0. Let's hold off on merging #323 until the next release since it's non-critical.

@TonyB9000
Copy link
Contributor

@tomvothecoder There were no issues found in the code for replacing NaN values in the clisccp handler - it worked great. Of course, other aspects of testing (deliberately providing other sorts of bad data to exercise other failure modes) was not done.

I can deal with the ambiguous E2C return codes by distrusting/ignoring the return value and independently applying a more robust measure of success (above and beyond "all the files were generated"). Perhaps scanning the cmor_logs and e2c_logs automatically will suffice.

@tomvothecoder
Copy link
Collaborator Author

@tomvothecoder There were no issues found in the code for replacing NaN values in the clisccp handler - it worked great. Of course, other aspects of testing (deliberately providing other sorts of bad data to exercise other failure modes) was not done.

I can deal with the ambiguous E2C return codes by distrusting/ignoring the return value and independently applying a more robust measure of success (above and beyond "all the files were generated"). Perhaps scanning the cmor_logs and e2c_logs automatically will suffice.

Okay, I will release v1.13.0 on Monday given that things look good so far.

@chengzhuzhang
Copy link
Collaborator

Okay, I will release v1.13.0 on Monday given that things look good so far.

Sounds good to me! Thanks.

@tomvothecoder tomvothecoder marked this pull request as ready for review November 3, 2025 18:01
@tomvothecoder tomvothecoder self-assigned this Nov 3, 2025
@tomvothecoder tomvothecoder merged commit 6e498a4 into master Nov 3, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in E3SM to CMIP Development Nov 3, 2025
@tomvothecoder tomvothecoder deleted the bump/v1.13.0 branch November 3, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants