Skip to content

Conversation

@altheaden
Copy link
Collaborator

This PR is just to update the config_machines.xml file from E3SM. I also updated some of the values we have in the files for each of the machines, as needed.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added in progress This PR is not ready for review or merging config-machines Changes to the config_machines.xml file labels Sep 13, 2024
@altheaden
Copy link
Collaborator Author

altheaden commented Sep 13, 2024

@xylar I set this PR to "in progress" for now because there are some machine files I haven't looked at yet to see if some of the older changes should be implemented. I'll put some notes here for you to look at and we can discuss. Also, since there are some pending changes in E3SM relating to Compy, we might want to include those in this PR as well.

After this PR is merged, I'll make two PRs for adding Aurora and Sunspot.

@altheaden altheaden changed the title Update config machines Update config_machines.xml Sep 13, 2024
@altheaden altheaden changed the title Update config_machines.xml Update config_machines.xml Sep 13, 2024
@altheaden altheaden changed the title Update config_machines.xml Update config_machines.xml Sep 13, 2024
@xylar
Copy link
Collaborator

xylar commented Sep 22, 2024

Note that there are some more recent changes to include:
E3SM-Project/E3SM#6596
E3SM-Project/E3SM#6603

@xylar
Copy link
Collaborator

xylar commented Sep 22, 2024

@altheaden, this looks excellent so far!

@altheaden altheaden force-pushed the update-config-machines branch from 2c55dc7 to d2925ef Compare September 24, 2024 22:53
@altheaden altheaden force-pushed the update-config-machines branch from d2925ef to 2f1d2f9 Compare September 24, 2024 22:57
@altheaden
Copy link
Collaborator Author

@xylar I just rolled in the changes from the two E3SM PRs you mentioned and updated the appropriate files. I think all the spack files should be up to date now, along with config_machines.xml.

@xylar
Copy link
Collaborator

xylar commented Sep 25, 2024

@altheaden, this all looks great to me! I think doing thorough testing of spack builds now using these changes will be too time consuming to be worthwhile. So my suggestion is that we merge these changes and then test them thoroughly the next time we need to update E3SM-Unified, Polaris or Compass.

I'm testing things out on Compy right now so we'll at least be able to see if those changes work.

@xylar xylar added the spack Changes relate to creating conda and Spack environments, and creating a load script label Sep 25, 2024
@xylar xylar self-assigned this Sep 25, 2024
@altheaden altheaden force-pushed the update-config-machines branch from 36b4757 to 2f1d2f9 Compare September 25, 2024 18:23
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. As long as you think it's done, let's go ahead and merge it.

@altheaden
Copy link
Collaborator Author

Sure, go ahead!

@xylar xylar removed the in progress This PR is not ready for review or merging label Sep 25, 2024
@xylar xylar merged commit eef533f into E3SM-Project:main Sep 25, 2024
5 checks passed
@xylar xylar deleted the update-config-machines branch September 25, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config-machines Changes to the config_machines.xml file spack Changes relate to creating conda and Spack environments, and creating a load script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants