-
Notifications
You must be signed in to change notification settings - Fork 8
Update config_machines.xml
#193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@xylar I set this PR to "in progress" for now because there are some machine files I haven't looked at yet to see if some of the older changes should be implemented. I'll put some notes here for you to look at and we can discuss. Also, since there are some pending changes in E3SM relating to Compy, we might want to include those in this PR as well. After this PR is merged, I'll make two PRs for adding Aurora and Sunspot. |
|
Note that there are some more recent changes to include: |
|
@altheaden, this looks excellent so far! |
2c55dc7 to
d2925ef
Compare
d2925ef to
2f1d2f9
Compare
|
@xylar I just rolled in the changes from the two E3SM PRs you mentioned and updated the appropriate files. I think all the spack files should be up to date now, along with |
|
@altheaden, this all looks great to me! I think doing thorough testing of spack builds now using these changes will be too time consuming to be worthwhile. So my suggestion is that we merge these changes and then test them thoroughly the next time we need to update E3SM-Unified, Polaris or Compass. I'm testing things out on Compy right now so we'll at least be able to see if those changes work. |
36b4757 to
2f1d2f9
Compare
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. As long as you think it's done, let's go ahead and merge it.
|
Sure, go ahead! |
This PR is just to update the
config_machines.xmlfile from E3SM. I also updated some of the values we have in the files for each of the machines, as needed.Checklist
Testingcomment in the PR documents testing used to verify the changes