Fix Perlmutter nvidia spack #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
TestingDeployed test spack builds with nvidia and nvidiagpu on Perlmutter using these fixes. Without them, spack fails to build |
Collaborator
Author
|
@altheaden, could you approve this PR based on your testing so I can merge it? |
altheaden
approved these changes
Nov 19, 2024
Collaborator
altheaden
left a comment
altheaden
left a comment
There was a problem hiding this comment.
Yep, looks good to me. With these changes I was able to build the environments for both nvidia on pm-cpu and nvidiagpu on pm-gpu with no issues.
Collaborator
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Testingcomment in the PR documents testing used to verify the changes