Skip to content

Update pm-cpu and pm-gpu spack templates with latest modules #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 24, 2025
Merged

Update pm-cpu and pm-gpu spack templates with latest modules #306

merged 13 commits into from
Oct 24, 2025

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Oct 16, 2025

This merge also updates config_machines.xml to bring in updates to Perlmuter CPU and GPU modules (E3SM-Project/E3SM#7740). This version of config_machines.xml corresponds to https://github.com/E3SM-Project/E3SM/blob/37bf054cb4d8b6bbc3dbc6d4a377ce183f6375cd/cime_config/machines/config_machines.xml

altheaden and others added 13 commits October 2, 2025 12:46
@altheaden @xylar
Set module loading in cfgs to false for all mach
882daa6
@altheaden @xylar
Remove module loading from mache.spack.script
3a4d753
@altheaden @xylar
Remove modules from mache.spack.env
37b02db
@xylar
Remove unused _get_modules() function
5387b2e
@xylar
Remove modules_before and modules_after from configs
3ba5759
@xylar
remove unused yaml_template parameter
e5b4967 
...from get_modules_env_vars_and_mpi_compilers() and
get_spack_script()
@xylar
Add shell script from config_machines.xml to spack load script
1b411b9
@xylar
Don't leave blank lines for if e3sm_hdf5_netcdf from templates
6476701
@xylar
Remove unneeded shell templates
18fff55 
Almost all shell templates appear to be interchangable with their
auto-generated counterparts from machine_configs.xml.

Perlmutter CPU and GPU still need a little trick to set $NERSC_HOST
if it isn't defined.
@andrewdnolan @xylar
Parse config_machine.xml path using importlib
d002f2c
@xylar
Combine shell-script templates, then render them
76fc246 
Before this fix, the autogenerated shell scripts were not getting
rendered as jinja templates
@xylar
Update config_machines.xml
7071b6b 
This brings in updates to Perlmuter CPU and GPU modules and
corresponds to E3SM commit hash:
37bf054cb4d8b6bbc3dbc6d4a377ce183f6375cd
@xylar
Update pm-cpu and pm-gpu spack templates with latest modules
50cea0b
@xylar xylar self-assigned this Oct 16, 2025
@xylar xylar added spack Changes relate to creating conda and Spack environments, and creating a load script config-machines Changes to the config_machines.xml file labels Oct 16, 2025
@xylar xylar requested a review from andrewdnolan October 16, 2025 12:47
@andrewdnolan andrewdnolan marked this pull request as ready for review October 20, 2025 15:00
@andrewdnolan
Copy link
Collaborator

andrewdnolan commented Oct 20, 2025

I just looked through the last two commits, but those seem good to me.

The only thing worth mentioning is the latest changes to pm-cpu_nvidia have caused a lot of E3SM test to fail: https://my.cdash.org/builds/3148732. I don't necessarily think that should stop us, but just wanted to mention so we are aware if anything downstream breaks. (Although I don't think the nvidia compiler is super widely used).

@xylar
Copy link
Collaborator Author

xylar commented Oct 20, 2025

@andrewdnolan, other commits are all from #304, so perfect!

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2025

Testing

I was able to deploy E3SM-Unified on Perlmuter with these updates. I feel confident enough that things are working to merge.

@andrewdnolan ran into some trouble with libfabric but this appears to have been resolved by deleting ~/.spack.

@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2025

The only thing worth mentioning is the latest changes to pm-cpu_nvidia have caused a lot of E3SM test to fail: https://my.cdash.org/builds/3148732. I don't necessarily think that should stop us, but just wanted to mention so we are aware if anything downstream breaks. (Although I don't think the nvidia compiler is super widely used).

I don't believe any of E3SM-Unified, Polaris or Compass support pm-cpu with nvidia. But even if so, it seems like trouble there might not be a good reason to hold up this update. We can always follow up with another update later once things get sorted out on the E3SM side.

@xylar xylar merged commit 592aaa9 into E3SM-Project:main Oct 24, 2025
5 checks passed
@xylar
Copy link
Collaborator Author

xylar commented Oct 24, 2025

Ack, shoot! I didn't mean to merge #303 as well!! I'll revert!

xylar added a commit to xylar/mache that referenced this pull request Oct 24, 2025
@xylar
Revert "Merge pull request E3SM-Project#306 from xylar/update-pm"
b1ea6c0 
This reverts commit 592aaa9, reversing
changes made to 9357439.
@xylar xylar mentioned this pull request Oct 24, 2025
Merged
7 tasks
xylar added a commit that referenced this pull request Oct 24, 2025
@xylar
Merge pull request #312 from xylar/revert-update-pm
239a66a 
Revert "Merge pull request #306 from xylar/update-pm"
@xylar xylar mentioned this pull request Oct 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewdnolan andrewdnolan andrewdnolan approved these changes

Assignees

@xylar xylar

Labels

config-machines Changes to the config_machines.xml file spack Changes relate to creating conda and Spack environments, and creating a load script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xylar @andrewdnolan @altheaden