-
Notifications
You must be signed in to change notification settings - Fork 8
Speed up permission updates #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up permission updates #307
Conversation
Remove nested for loops and parallelize updating using threads. Also switched to tqdm for the progress bar updating.
Add docstring and make progress bar optional.
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Feel free to merge when you're ready. |
Also switched to pass from continue so that subdirs are properly itterated.
Testing:Setting up the test directory: I intentionally changed the |
This PR speeds up the file permission updating by removing nested for loops and added the ability to parallelize the file permission departures over threads.
Checklist
Testingcomment, if appropriate, in the PR documents testing used to verify the changes