Skip to content

Conversation

@andrewdnolan
Copy link
Collaborator

Such that both files and directories are accepted as arguments.

Checklist

  • User's Guide has been updated if needed
  • Developer's Guide has been updated if needed
  • API documentation lists any new or modified class, method, or function
  • Documentation builds cleanly and changes look as expected
  • Tests pass and new features are covered by tests
  • PR description includes a summary and any relevant issue references
  • Testing comment, if appropriate, in the PR documents testing used to verify the changes

Such that both files and directories are accepeted as
arguments
@andrewdnolan andrewdnolan requested a review from xylar October 23, 2025 13:11
@andrewdnolan andrewdnolan added the enhancement New feature or request label Oct 23, 2025
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@xylar
Copy link
Collaborator

xylar commented Oct 23, 2025

@andrewdnolan, as long as you've tested this, feel free to merge.

@andrewdnolan
Copy link
Collaborator Author

I've tested with mock directories, but also just a proper e3sm-unified test now. I has a successfull test deployment on pm-cpu, but I killed the script before the permission could be updated. Ran with this branch rebased onto update-to-2.0.0.

Everything looks as expected:

Updating file permissions for: /pscratch/sd/a/anolan/e3sm_unified_1_12_0rc2
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 532333/532333 [07:06<00:00, 1249.35item/s]
Updating file permissions for: /pscratch/sd/a/anolan/test_e3sm_unified_1.12.0rc2_pm-cpu.sh
Updating file permissions for: /pscratch/sd/a/anolan/test_e3sm_unified_1.12.0rc2_pm-cpu.csh

And the permissions look correct:

ls -ld /pscratch/sd/a/anolan/*e3sm_unified*
drwxr-xr-x 3 anolan e3sm 4096 Oct 22 13:37 /pscratch/sd/a/anolan/e3sm_unified_1_12_0rc2
-rw-r--r-- 1 anolan e3sm 1904 Oct 23 07:27 /pscratch/sd/a/anolan/test_e3sm_unified_1.12.0rc2_pm-cpu.csh
-rw-r--r-- 1 anolan e3sm 2020 Oct 23 07:27 /pscratch/sd/a/anolan/test_e3sm_unified_1.12.0rc2_pm-cpu.sh

With that complete I'll merge.

@andrewdnolan andrewdnolan merged commit 1e07ea7 into E3SM-Project:main Oct 23, 2025
5 checks passed
@andrewdnolan andrewdnolan deleted the simplify_permissions branch October 23, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants