add cartopy <= 0.24.0 constraint #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Thanks for building cartopy 0.24.0 for python 3.14, @xylar! |
xylar
requested changes
Oct 27, 2025
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
It would be a little safer and more standard to constrain with < than with <=. This is partly because it indicates the problem version and partly because it works well even if you exclude the patch version (i.e. <0.25 works but <=0.24 doesn't necessarily).
|
|
||
| dependencies = [ | ||
| "cartopy", | ||
| "cartopy<=0.24.0", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "cartopy<=0.24.0", | |
| "cartopy<0.25.0", |
| @@ -1,5 +1,5 @@ | |||
| python >= 3.10 | |||
| cartopy | |||
| cartopy <=0.24.0 | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| cartopy <=0.24.0 | |
| cartopy <0.25.0 |
Collaborator
|
Woops, I was too late. Doesn't matter. Just for future reference, then. |
Collaborator
Author
|
Sorry for jumping the gun. Good to know going forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Will work on opening an issue in
cartopyto get this issue addressed.