Fixup graph paths for cached inputs #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
TestingIcos cosine bell convergence test has been tested with cached inputs on chrys with intel, impi. |
xylar
approved these changes
Oct 10, 2024
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
Yep, that makes a lot of sense to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a small bug introduced by #225. When inputs are cached, we need to point to the mesh step rather than the init step for the graph files. Doesn't hurt to point to the mesh step when inputs are not cached either.